From 5f2d07f9219f5469f14138fdcf5ba5409b3f51df Mon Sep 17 00:00:00 2001 From: Jake Turner Date: Thu, 10 Jul 2025 07:52:38 +0100 Subject: [PATCH] Initialise output window semaphore to VK_NULL_HANDLE In case CreateSemaphore() fails and the semaphore is not valid which could lead to a problem/crash in DestroySemaphore --- renderdoc/driver/vulkan/vk_outputwindow.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/renderdoc/driver/vulkan/vk_outputwindow.cpp b/renderdoc/driver/vulkan/vk_outputwindow.cpp index 2dd770c15..fe07c08fa 100644 --- a/renderdoc/driver/vulkan/vk_outputwindow.cpp +++ b/renderdoc/driver/vulkan/vk_outputwindow.cpp @@ -943,7 +943,7 @@ void VulkanReplay::BindOutputWindow(uint64_t id, bool depth) { // semaphore is short lived, so not wrapped, if it's cached (ideally) // then it should be wrapped - VkSemaphore sem; + VkSemaphore sem = VK_NULL_HANDLE; VkPipelineStageFlags stage = VK_PIPELINE_STAGE_BOTTOM_OF_PIPE_BIT; VkSemaphoreCreateInfo semInfo = {VK_STRUCTURE_TYPE_SEMAPHORE_CREATE_INFO, NULL, 0};