diff --git a/qrenderdoc/3rdparty/toolwindowmanager/ToolWindowManager.cpp b/qrenderdoc/3rdparty/toolwindowmanager/ToolWindowManager.cpp index 478d49731..c5ac7d59c 100644 --- a/qrenderdoc/3rdparty/toolwindowmanager/ToolWindowManager.cpp +++ b/qrenderdoc/3rdparty/toolwindowmanager/ToolWindowManager.cpp @@ -148,10 +148,10 @@ void ToolWindowManager::moveToolWindows(QList toolWindows, if (area.type() == NoArea) { //do nothing } else if (area.type() == NewFloatingArea) { - ToolWindowManagerArea* area = createArea(); - area->addToolWindows(toolWindows); + ToolWindowManagerArea* floatArea = createArea(); + floatArea->addToolWindows(toolWindows); ToolWindowManagerWrapper* wrapper = new ToolWindowManagerWrapper(this); - wrapper->layout()->addWidget(area); + wrapper->layout()->addWidget(floatArea); wrapper->move(QCursor::pos()); wrapper->show(); } else if (area.type() == AddTo) { @@ -535,13 +535,13 @@ QVariantMap ToolWindowManager::saveSplitterState(QSplitter *splitter) { return result; } -QSplitter *ToolWindowManager::restoreSplitterState(const QVariantMap &data) { - if (data["items"].toList().count() < 2) { +QSplitter *ToolWindowManager::restoreSplitterState(const QVariantMap &savedData) { + if (savedData["items"].toList().count() < 2) { qWarning("invalid splitter encountered"); } QSplitter* splitter = createSplitter(); - foreach(QVariant itemData, data["items"].toList()) { + foreach(QVariant itemData, savedData["items"].toList()) { QVariantMap itemValue = itemData.toMap(); QString itemType = itemValue["type"].toString(); if (itemType == "splitter") { @@ -554,7 +554,7 @@ QSplitter *ToolWindowManager::restoreSplitterState(const QVariantMap &data) { qWarning("unknown item type"); } } - splitter->restoreState(QByteArray::fromBase64(data["state"].toByteArray())); + splitter->restoreState(QByteArray::fromBase64(savedData["state"].toByteArray())); return splitter; } @@ -650,14 +650,14 @@ void ToolWindowManager::findSuggestions(ToolWindowManagerWrapper* wrapper) { continue; } - ToolWindowManagerArea* area = qobject_cast(parent); - ToolWindowManagerWrapper* wrapper = qobject_cast(parent); + ToolWindowManagerArea* areaParent = qobject_cast(parent); + ToolWindowManagerWrapper* wrapperParent = qobject_cast(parent); // if it's an area or wrapper, check if it's ours - if(area) - valid = area->manager() == this; - else if(wrapper) - valid = wrapper->manager() == this; + if(areaParent) + valid = areaParent->manager() == this; + else if(wrapperParent) + valid = wrapperParent->manager() == this; // we're done now, whether we checked for validity, or if we // found something that's none of the above @@ -672,7 +672,7 @@ void ToolWindowManager::findSuggestions(ToolWindowManagerWrapper* wrapper) { candidates << area; } } - foreach(QWidget* widget, candidates) { + for(QWidget* widget : candidates) { QSplitter* splitter = qobject_cast(widget); ToolWindowManagerArea* area = qobject_cast(widget); if (!splitter && !area) { @@ -700,7 +700,7 @@ void ToolWindowManager::findSuggestions(ToolWindowManagerWrapper* wrapper) { allowedSides << BottomOf; } } - foreach(AreaReferenceType side, allowedSides) { + for(AreaReferenceType side : allowedSides) { if (sideSensitiveArea(widget, side).contains(widget->mapFromGlobal(globalPos))) { m_suggestions << AreaReference(side, widget); } diff --git a/qrenderdoc/3rdparty/toolwindowmanager/ToolWindowManagerArea.cpp b/qrenderdoc/3rdparty/toolwindowmanager/ToolWindowManagerArea.cpp index 5e0417d7c..c6f71f8b2 100644 --- a/qrenderdoc/3rdparty/toolwindowmanager/ToolWindowManagerArea.cpp +++ b/qrenderdoc/3rdparty/toolwindowmanager/ToolWindowManagerArea.cpp @@ -194,14 +194,14 @@ QVariantMap ToolWindowManagerArea::saveState() { return result; } -void ToolWindowManagerArea::restoreState(const QVariantMap &data) { - foreach(QVariant object, data["objects"].toList()) { +void ToolWindowManagerArea::restoreState(const QVariantMap &savedData) { + for(QVariant object : savedData["objects"].toList()) { QVariantMap objectData = object.toMap(); if (objectData.isEmpty()) { continue; } QString objectName = objectData["name"].toString(); if (objectName.isEmpty()) { continue; } QWidget *t = NULL; - foreach(QWidget* toolWindow, m_manager->m_toolWindows) { + for(QWidget* toolWindow : m_manager->m_toolWindows) { if (toolWindow->objectName() == objectName) { t = toolWindow; break; @@ -215,7 +215,7 @@ void ToolWindowManagerArea::restoreState(const QVariantMap &data) { qWarning("tool window with name '%s' not found or created", objectName.toLocal8Bit().constData()); } } - setCurrentIndex(data["currentIndex"].toInt()); + setCurrentIndex(savedData["currentIndex"].toInt()); } void ToolWindowManagerArea::check_mouse_move() { diff --git a/qrenderdoc/3rdparty/toolwindowmanager/ToolWindowManagerWrapper.cpp b/qrenderdoc/3rdparty/toolwindowmanager/ToolWindowManagerWrapper.cpp index 3d3ed3ec6..6fc161923 100644 --- a/qrenderdoc/3rdparty/toolwindowmanager/ToolWindowManagerWrapper.cpp +++ b/qrenderdoc/3rdparty/toolwindowmanager/ToolWindowManagerWrapper.cpp @@ -81,17 +81,17 @@ QVariantMap ToolWindowManagerWrapper::saveState() { return result; } -void ToolWindowManagerWrapper::restoreState(const QVariantMap &data) { - restoreGeometry(QByteArray::fromBase64(data["geometry"].toByteArray())); +void ToolWindowManagerWrapper::restoreState(const QVariantMap &savedData) { + restoreGeometry(QByteArray::fromBase64(savedData["geometry"].toByteArray())); if (layout()->count() > 0) { qWarning("wrapper is not empty"); return; } - if (data.contains("splitter")) { - layout()->addWidget(m_manager->restoreSplitterState(data["splitter"].toMap())); - } else if (data.contains("area")) { + if (savedData.contains("splitter")) { + layout()->addWidget(m_manager->restoreSplitterState(savedData["splitter"].toMap())); + } else if (savedData.contains("area")) { ToolWindowManagerArea* area = m_manager->createArea(); - area->restoreState(data["area"].toMap()); + area->restoreState(savedData["area"].toMap()); layout()->addWidget(area); } } diff --git a/qrenderdoc/qrenderdoc_local.vcxproj b/qrenderdoc/qrenderdoc_local.vcxproj index aae5c8ad7..5f5832a87 100644 --- a/qrenderdoc/qrenderdoc_local.vcxproj +++ b/qrenderdoc/qrenderdoc_local.vcxproj @@ -729,7 +729,6 @@ - Level3 @@ -746,13 +745,10 @@ - Level3 - Level3 - Level3 @@ -1584,4 +1580,4 @@ - + \ No newline at end of file