From 657def5fb21fe06b9757486cd8da93ee9fbfe548 Mon Sep 17 00:00:00 2001 From: baldurk Date: Wed, 10 May 2017 10:24:58 +0100 Subject: [PATCH] Refactor out-of-bounds check to handle negative (~0U in uint) idxs --- renderdoc/driver/shaders/dxbc/dxbc_debug.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/renderdoc/driver/shaders/dxbc/dxbc_debug.cpp b/renderdoc/driver/shaders/dxbc/dxbc_debug.cpp index 3179bd73f..5c6e763c7 100644 --- a/renderdoc/driver/shaders/dxbc/dxbc_debug.cpp +++ b/renderdoc/driver/shaders/dxbc/dxbc_debug.cpp @@ -962,7 +962,7 @@ ShaderVariable State::GetSrc(const ASMOperand &oper, const ASMOperation &op) con v = s = ShaderVariable("", 0, 0, 0, 0); // if this Vec4f is entirely in the ICB - if(indices[0] * 4 + 4 <= dxbc->m_Immediate.size()) + if(indices[0] <= dxbc->m_Immediate.size() / 4 - 1) { memcpy(s.value.uv, &dxbc->m_Immediate[indices[0] * 4], sizeof(Vec4f)); }