From 65859d13bff381f7e39db026006d3885c0b249fd Mon Sep 17 00:00:00 2001 From: baldurk Date: Thu, 3 Aug 2023 14:21:17 +0100 Subject: [PATCH] Add test of Set*Root32BitConstants with 0 constants being set * This crashes on nvidia, on compute only strangely, if we pass in a NULL pointer along with a 0 number of constants. --- util/test/demos/d3d12/d3d12_parameter_zoo.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/util/test/demos/d3d12/d3d12_parameter_zoo.cpp b/util/test/demos/d3d12/d3d12_parameter_zoo.cpp index 0d4060f1e..3158155c2 100644 --- a/util/test/demos/d3d12/d3d12_parameter_zoo.cpp +++ b/util/test/demos/d3d12/d3d12_parameter_zoo.cpp @@ -142,8 +142,8 @@ float4 main() : SV_Target0 ID3D12RootSignaturePtr duplicateSig = MakeSig( { - cbvParam(D3D12_SHADER_VISIBILITY_PIXEL, 0, 0), - constParam(D3D12_SHADER_VISIBILITY_PIXEL, 0, 1, 1), + cbvParam(D3D12_SHADER_VISIBILITY_ALL, 0, 0), + constParam(D3D12_SHADER_VISIBILITY_ALL, 0, 1, 1), }, D3D12_ROOT_SIGNATURE_FLAG_NONE); @@ -347,6 +347,10 @@ float4 main() : SV_Target0 cmd->SetDescriptorHeaps(2, heaps); + cmd->SetComputeRootSignature(duplicateSig); + cmd->SetComputeRoot32BitConstants(1, 0, &debug, 0); + cmd->SetGraphicsRoot32BitConstants(1, 0, &debug, 0); + IASetVertexBuffer(cmd, vb2, sizeof(DefaultA2V), 0); IASetVertexBuffer(cmd, vb, sizeof(DefaultA2V), 0); D3D12_INDEX_BUFFER_VIEW view;