From 66574fd2bb346aa42326758060909217d9f3605f Mon Sep 17 00:00:00 2001 From: Jake Turner Date: Thu, 6 Jul 2023 12:41:34 +0100 Subject: [PATCH] Test null DSV in D3D12::GetRenderOutputSubresource Prevents a crash when refreshing the overlay for am unbound Texture resource and the pipeline state does not have a bound DSV. Related to 742e3de2 which changed the internal behaviour of FillResourceView(). --- renderdoc/driver/d3d12/d3d12_overlay.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/renderdoc/driver/d3d12/d3d12_overlay.cpp b/renderdoc/driver/d3d12/d3d12_overlay.cpp index c6e1cdadf..704712125 100644 --- a/renderdoc/driver/d3d12/d3d12_overlay.cpp +++ b/renderdoc/driver/d3d12/d3d12_overlay.cpp @@ -956,7 +956,7 @@ RenderOutputSubresource D3D12Replay::GetRenderOutputSubresource(ResourceId id) } } - if(id == rs.dsv.GetResResourceId()) + if(id == rs.dsv.GetResResourceId() && rs.dsv.GetResResourceId() != ResourceId()) { FillResourceView(view, &rs.dsv); return RenderOutputSubresource(view.firstMip, view.firstSlice, view.numSlices);