From 6931c4d93b59593bec72fd7349df80aabfc3fa46 Mon Sep 17 00:00:00 2001 From: Jake Turner Date: Sat, 9 Apr 2022 06:26:20 +0100 Subject: [PATCH] PR Feedback for WrappedMTLCommandBuffer Moved small inline methods to be inside the class declaration instead of outside --- renderdoc/driver/metal/metal_command_buffer.h | 21 +++++++------------ 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/renderdoc/driver/metal/metal_command_buffer.h b/renderdoc/driver/metal/metal_command_buffer.h index 434bf3e04..ae7345157 100644 --- a/renderdoc/driver/metal/metal_command_buffer.h +++ b/renderdoc/driver/metal/metal_command_buffer.h @@ -35,9 +35,15 @@ public: WrappedMTLCommandBuffer(MTL::CommandBuffer *realMTLCommandBuffer, ResourceId objId, WrappedMTLDevice *wrappedMTLDevice); - void SetWrappedMTLCommandQueue(WrappedMTLCommandQueue *wrappedMTLCommandQueue); + void SetWrappedMTLCommandQueue(WrappedMTLCommandQueue *wrappedMTLCommandQueue) + { + m_WrappedMTLCommandQueue = wrappedMTLCommandQueue; + } - MTL::CommandQueue *GetObjCBridgeMTLCommandQueue(); + MTL::CommandQueue *GetObjCBridgeMTLCommandQueue() + { + return GetObjCBridge(m_WrappedMTLCommandQueue); + } DECLARE_FUNCTION_SERIALISED(void, presentDrawable, MTL::Drawable *drawable); DECLARE_FUNCTION_SERIALISED(void, commit); @@ -50,14 +56,3 @@ public: private: WrappedMTLCommandQueue *m_WrappedMTLCommandQueue; }; - -inline MTL::CommandQueue *WrappedMTLCommandBuffer::GetObjCBridgeMTLCommandQueue() -{ - return GetObjCBridge(m_WrappedMTLCommandQueue); -} - -inline void WrappedMTLCommandBuffer::SetWrappedMTLCommandQueue( - WrappedMTLCommandQueue *wrappedMTLCommandQueue) -{ - m_WrappedMTLCommandQueue = wrappedMTLCommandQueue; -}