lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-08-25 07:56:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add fallback logic to make AddDockWindow place panels somewhere

Browse Source 
* We also handle the main window being passed in as the reference - since it's
  the one widget which isn't a child of a docking system itself.
This commit is contained in:
baldurk
2026-08-13 17:46:46 +01:00
parent 2d0ba78a49
commit 6e2069ec54
1 changed files with 58 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
qrenderdoc/Code/CaptureContext.cpp
+58 -1
View File
@@ -2898,11 +2898,59 @@ void CaptureContext::AddDockWindow(QWidget *newWindow, DockReference ref, QWidge
newWindow, ToolWindowManager::AreaReference(ToolWindowManager::LastUsedArea));
return;
}
else if(ref == DockReference::NoArea)
{
m_MainWindow->mainToolManager()->addToolWindow(
newWindow, ToolWindowManager::AreaReference(ToolWindowManager::NoArea));
return;
}
else if(ref == DockReference::EmptySpace)
{
m_MainWindow->mainToolManager()->addToolWindow(
newWindow, ToolWindowManager::AreaReference(ToolWindowManager::EmptySpace));
return;
}
if(!refWindow)
{
// expect a reference window for all other docking types
// try to decay down to the main window so that we place the window somewhere
qCritical() << "Unexpected NULL refWindow in AddDockWindow";
return;
// AddTo doesn't have any fallback - put it in the main area.
if(ref == DockReference::AddTo)
{
m_MainWindow->mainToolManager()->addToolWindow(newWindow, m_MainWindow->mainToolArea());
return;
}
// if this was meant to be relative to a panel instead put it relative to the whole window
if(ref == DockReference::LeftOf)
ref = DockReference::LeftWindowSide;
if(ref == DockReference::RightOf)
ref = DockReference::RightWindowSide;
if(ref == DockReference::TopOf)
ref = DockReference::TopWindowSide;
if(ref == DockReference::BottomOf)
ref = DockReference::BottomWindowSide;
}
if(refWindow == m_MainWindow)
refWindow = NULL;
if(!refWindow)
{
// we're now placing only relative to a whole window so the particular widget we pick doesn't
// matter. pick something
if(!m_MainWindow->mainToolManager()->toolWindows().isEmpty())
{
refWindow = m_MainWindow->mainToolManager()->toolWindows()[0];
}
else
{
// if there are no tool windows at all we're panicking! just put it in empty space
ref = DockReference::EmptySpace;
}
}
if(ref == DockReference::TransientPopupArea)
@@ -2913,6 +2961,9 @@ void CaptureContext::AddDockWindow(QWidget *newWindow, DockReference ref, QWidge
{
ToolWindowManager *manager = ToolWindowManager::managerOf(refWindow);
if(!manager)
manager = m_MainWindow->mainToolManager();
BufferViewer *cb = BufferViewer::GetFirstCBufferView(buf);
if(cb)
{
@@ -2935,6 +2986,9 @@ void CaptureContext::AddDockWindow(QWidget *newWindow, DockReference ref, QWidge
{
ToolWindowManager *manager = ToolWindowManager::managerOf(refWindow);
if(!manager)
manager = m_MainWindow->mainToolManager();
PixelHistoryView *hist = manager->findChild<PixelHistoryView *>();
if(hist)
{
@@ -2949,6 +3003,9 @@ void CaptureContext::AddDockWindow(QWidget *newWindow, DockReference ref, QWidge
ToolWindowManager *manager = ToolWindowManager::managerOf(refWindow);
if(!manager)
manager = m_MainWindow->mainToolManager();
ToolWindowManager::AreaReference areaRef((ToolWindowManager::AreaReferenceType)ref,
manager->areaOf(refWindow), percentage);
manager->addToolWindow(newWindow, areaRef);