Rename 'draw' or 'drawcall' to action

* There's not a good accepted terminology for this kind of event, and for
  historical reasons 'drawcall' has been the accepted term, even though
  that can be quite confusing when a dispatch or a copy is a 'drawcall'.
* This is particularly highlighted by the event browser filters where
  $draw() includes draws and dispatches, but $dispatch() only includes
  dispatches, it's hard to intuitively understand why $draw() matches all
  of these calls.
* As a result we've defined the term 'action' to cover these types of
  events in the same way that we defined 'event' in the first place to
  mean a single atomic API call.
This commit is contained in:
baldurk
2021-07-01 15:15:05 +01:00
parent e7785bd99e
commit 7149302680
283 changed files with 5374 additions and 5320 deletions
+9 -9
View File
@@ -104,17 +104,17 @@ void DisplayRendererPreview(IReplayController *renderer, uint32_t width, uint32_
}
}
rdcarray<DrawcallDescription> draws = renderer->GetDrawcalls();
rdcarray<ActionDescription> actions = renderer->GetRootActions();
DrawcallDescription *last = NULL;
ActionDescription *last = NULL;
if(!draws.empty())
last = &draws.back();
if(!actions.empty())
last = &actions.back();
while(last && !last->children.empty())
last = &last->children.back();
if(last && last->flags & DrawFlags::Present)
if(last && last->flags & ActionFlags::Present)
{
ResourceId id = last->copyDestination;
if(id != ResourceId())
@@ -1614,8 +1614,8 @@ int renderdoccmd(GlobalEnvironment &env, std::vector<std::string> &argv)
"Capturing Option: Unmutes API debugging output from --opt-api-validation.");
cmd.add("opt-capture-callstacks", 0,
"Capturing Option: Capture CPU callstacks for API events.");
cmd.add("opt-capture-callstacks-only-draws", 0,
"Capturing Option: When capturing CPU callstacks, only capture them from drawcalls.");
cmd.add("opt-capture-callstacks-only-actions", 0,
"Capturing Option: When capturing CPU callstacks, only capture them from actions.");
cmd.add<int>("opt-delay-for-debugger", 0,
"Capturing Option: Specify a delay in seconds to wait for a debugger to attach.",
false, 0, cmdline::range(0, 10000));
@@ -1647,8 +1647,8 @@ int renderdoccmd(GlobalEnvironment &env, std::vector<std::string> &argv)
opts.debugOutputMute = false;
if(cmd.exist("opt-capture-callstacks"))
opts.captureCallstacks = true;
if(cmd.exist("opt-capture-callstacks-only-draws"))
opts.captureCallstacksOnlyDraws = true;
if(cmd.exist("opt-capture-callstacks-only-actions"))
opts.captureCallstacksOnlyActions = true;
if(cmd.exist("opt-verify-buffer-access"))
opts.verifyBufferAccess = true;
if(cmd.exist("opt-hook-children"))