lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-09-25 15:16:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix D3D12 debug error when setting constants in EI

Browse Source 
For instance would trigger when setting a single 32-bit root constant
Do not need to call resize_for_index() on constants because SetConstants() will handle any resizing that is required
This commit is contained in:
Jake Turner
2025-12-03 11:20:23 +13:00
parent abbe6d128a
commit 728ac77bf3
2 changed files with 0 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
renderdoc/driver/d3d12/d3d12_command_list_wrap.cpp
-4
View File
@@ -3952,16 +3952,12 @@ void WrappedID3D12GraphicsCommandList::FinaliseExecuteIndirectEvents(BakedCmdLis
if(arg.Constant.RootParameterIndex < state.graphics.sigelems.size())
{
state.graphics.sigelems[arg.Constant.RootParameterIndex].constants.resize_for_index(
arg.Constant.Num32BitValuesToSet + arg.Constant.DestOffsetIn32BitValues);
state.graphics.sigelems[arg.Constant.RootParameterIndex].SetConstants(
arg.Constant.Num32BitValuesToSet, data32, arg.Constant.DestOffsetIn32BitValues);
}
if(arg.Constant.RootParameterIndex < state.compute.sigelems.size())
{
state.compute.sigelems[arg.Constant.RootParameterIndex].constants.resize_for_index(
arg.Constant.Num32BitValuesToSet + arg.Constant.DestOffsetIn32BitValues);
state.compute.sigelems[arg.Constant.RootParameterIndex].SetConstants(
arg.Constant.Num32BitValuesToSet, data32, arg.Constant.DestOffsetIn32BitValues);
}
renderdoc/driver/d3d12/d3d12_state.cpp
-4
View File
@@ -110,16 +110,12 @@ void D3D12RenderState::ResolvePendingIndirectState(WrappedID3D12Device *device)
if(comSig->sig.graphics)
{
graphics.sigelems.resize_for_index(arg.Constant.RootParameterIndex);
graphics.sigelems[arg.Constant.RootParameterIndex].constants.resize_for_index(
arg.Constant.Num32BitValuesToSet + arg.Constant.DestOffsetIn32BitValues);
graphics.sigelems[arg.Constant.RootParameterIndex].SetConstants(
arg.Constant.Num32BitValuesToSet, data32, arg.Constant.DestOffsetIn32BitValues);
}
else
{
compute.sigelems.resize_for_index(arg.Constant.RootParameterIndex);
compute.sigelems[arg.Constant.RootParameterIndex].constants.resize_for_index(
arg.Constant.Num32BitValuesToSet + arg.Constant.DestOffsetIn32BitValues);
compute.sigelems[arg.Constant.RootParameterIndex].SetConstants(
arg.Constant.Num32BitValuesToSet, data32, arg.Constant.DestOffsetIn32BitValues);
}