lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-08-25 07:56:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix some integer sign extension/potential overflow issues.

Browse Source 
* Reported by Coverity Scan. In all cases, should not be a problem, but
  with an upcast happening anyway we might as well ensure calculation
  happens at a higher precision.
This commit is contained in:
baldurk
2017-11-22 19:11:22 +00:00
parent 43d561a4c0
commit 74e25673d2
10 changed files with 18 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
qrenderdoc/Windows/PipelineState/D3D11PipelineStateViewer.cpp
+2 -2
View File
@@ -1837,8 +1837,8 @@ void D3D11PipelineStateViewer::resource_itemActivated(RDTreeWidgetItem *item, in
if(view.res.Resource != ResourceId())
{
offs = view.res.FirstElement * view.res.ElementSize;
size = view.res.NumElements * view.res.ElementSize;
offs = uint64_t(view.res.FirstElement) * view.res.ElementSize;
size = uint64_t(view.res.NumElements) * view.res.ElementSize;
}
else
{
qrenderdoc/Windows/PipelineState/D3D12PipelineStateViewer.cpp
+1 -1
View File
@@ -1733,7 +1733,7 @@ void D3D12PipelineStateViewer::resource_itemActivated(RDTreeWidgetItem *item, in
if(view.res.Resource != ResourceId())
{
offs = view.res.FirstElement * view.res.ElementSize;
size = view.res.NumElements * view.res.ElementSize;
size = uint64_t(view.res.NumElements) * view.res.ElementSize;
}
else
{