From 7b8097690d3dba3afd5a3acaacf06b2cd9b450dd Mon Sep 17 00:00:00 2001 From: baldurk Date: Sat, 27 Feb 2016 14:53:52 +0100 Subject: [PATCH] Disable force-crash for errors/asserts/etc in profile * On balance I think this does more harm than good. The idea was to make sure errors don't get ignored when running in profile, but really all it did was mean people trying to debug renderdoc without much familiarity got confused as to why things crashed suddenly. --- renderdoc/common/common.h | 2 +- renderdoc/driver/shaders/spirv/spirv_disassemble.cpp | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/renderdoc/common/common.h b/renderdoc/common/common.h index ebb0a0dbf..17b922690 100644 --- a/renderdoc/common/common.h +++ b/renderdoc/common/common.h @@ -100,7 +100,7 @@ uint32_t CalcNumMips(int Width, int Height, int Depth); #define RDCDUMP() do { OSUtility::ForceCrash(); } while(0) #if !defined(RELEASE) || defined(FORCE_DEBUGBREAK) -#define RDCBREAK() do { if(OSUtility::DebuggerPresent()) OS_DEBUG_BREAK(); else RDCDUMP(); } while(0) +#define RDCBREAK() do { if(OSUtility::DebuggerPresent()) OS_DEBUG_BREAK(); } while(0) #else #define RDCBREAK() do { } while(0) #endif diff --git a/renderdoc/driver/shaders/spirv/spirv_disassemble.cpp b/renderdoc/driver/shaders/spirv/spirv_disassemble.cpp index 7697bac30..95eb1e2a0 100644 --- a/renderdoc/driver/shaders/spirv/spirv_disassemble.cpp +++ b/renderdoc/driver/shaders/spirv/spirv_disassemble.cpp @@ -4911,8 +4911,7 @@ void ParseSPIRV(uint32_t *spirv, size_t spirvLength, SPVModule &module) case spv::OpGroupDecorate: case spv::OpGroupMemberDecorate: case spv::OpDecorationGroup: - // TODO - RDCBREAK(); + RDCUNIMPLEMENTED("SPIR-V Group decorations"); break; default: break;