From 811ec2a5bdac299d35aced3dbecb896bbdd9ead0 Mon Sep 17 00:00:00 2001 From: Jake Turner Date: Sat, 3 Aug 2024 07:45:24 +0100 Subject: [PATCH] Do not crash in OpenCapture if m_RDC is NULL The NULL case was being handled for setting the return code and then Error() was being called on a NULL m_RDC --- renderdoc/replay/capture_file.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/renderdoc/replay/capture_file.cpp b/renderdoc/replay/capture_file.cpp index 2fb90e42d..3b3e0e5d6 100644 --- a/renderdoc/replay/capture_file.cpp +++ b/renderdoc/replay/capture_file.cpp @@ -355,7 +355,7 @@ rdcpair CaptureFile::OpenCapture(const Repla ReplayController *render = NULL; if(!m_RDC) - ret = RDResult(ResultCode::InternalError, "RDC file unexpectedly NULL"); + return {RDResult(ResultCode::InternalError, "RDC file unexpectedly NULL"), render}; ret = m_RDC->Error();