From 84331ebf0b126d4a33f1cf25468e519e9d6d00e4 Mon Sep 17 00:00:00 2001 From: baldurk Date: Thu, 21 Dec 2017 11:56:54 +0000 Subject: [PATCH] [Coverity] Fix missing check for negative return --- qrenderdoc/Windows/Dialogs/RemoteManager.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/qrenderdoc/Windows/Dialogs/RemoteManager.cpp b/qrenderdoc/Windows/Dialogs/RemoteManager.cpp index 37e5335c5..d4f356290 100644 --- a/qrenderdoc/Windows/Dialogs/RemoteManager.cpp +++ b/qrenderdoc/Windows/Dialogs/RemoteManager.cpp @@ -669,7 +669,10 @@ void RemoteManager::on_deleteHost_clicked() if(res == QMessageBox::Yes) { - size_t idx = m_Ctx.Config().RemoteHosts.indexOf(host); + int32_t idx = m_Ctx.Config().RemoteHosts.indexOf(host); + if(idx < 0) + return; + // the host will be removed in queueDelete. m_Ctx.Config().RemoteHosts.erase(idx); m_Ctx.Config().Save();