From 852e5381452184144b01d059299452f55220a4ea Mon Sep 17 00:00:00 2001 From: baldurk Date: Thu, 5 Sep 2019 20:32:33 +0100 Subject: [PATCH] Add missing boundary check in MemRefInterval iteration. Closes #1510 --- renderdoc/driver/vulkan/vk_manager.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/renderdoc/driver/vulkan/vk_manager.cpp b/renderdoc/driver/vulkan/vk_manager.cpp index dbeaed409..c2f1b7124 100644 --- a/renderdoc/driver/vulkan/vk_manager.cpp +++ b/renderdoc/driver/vulkan/vk_manager.cpp @@ -452,7 +452,8 @@ bool VulkanResourceManager::Serialise_DeviceMemoryRefs(SerialiserType &ser, // Compute the overall ref type for the dword, including all the ref types of intervals // intersecting the dword FrameRefType overlapRef = lastRef; - for(; it_data->start < nextDWord; ++it_data) + for(; it_data != data.end() && it_data->start < nextDWord && it_data->memory == mem; + ++it_data) overlapRef = ComposeFrameRefsDisjoint(overlapRef, it_data->refType); --it_data;