From 870f0cc16634667458ae8bb496a8f4a288f37552 Mon Sep 17 00:00:00 2001 From: baldurk Date: Thu, 11 May 2017 16:53:54 +0100 Subject: [PATCH] Filename filters should be translated --- qrenderdoc/Code/QRDUtils.cpp | 2 +- qrenderdoc/Windows/BufferViewer.cpp | 6 +++--- qrenderdoc/Windows/Dialogs/CaptureDialog.cpp | 4 ++-- qrenderdoc/Windows/EventBrowser.cpp | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/qrenderdoc/Code/QRDUtils.cpp b/qrenderdoc/Code/QRDUtils.cpp index 26b9289cd..30fae0de1 100644 --- a/qrenderdoc/Code/QRDUtils.cpp +++ b/qrenderdoc/Code/QRDUtils.cpp @@ -432,7 +432,7 @@ QString RDDialog::getExecutableFileName(QWidget *parent, const QString &caption, #if defined(Q_OS_WIN32) // can't filter by executable bit on windows, but we have extensions - filter = lit("Executables (*.exe);;All Files (*.*)"); + filter = QApplication::translate("RDDialog", "Executables (*.exe);;All Files (*.*)"); #endif QFileDialog fd(parent, caption, dir, filter); diff --git a/qrenderdoc/Windows/BufferViewer.cpp b/qrenderdoc/Windows/BufferViewer.cpp index 25fd5fcf5..074ab11cf 100644 --- a/qrenderdoc/Windows/BufferViewer.cpp +++ b/qrenderdoc/Windows/BufferViewer.cpp @@ -2819,12 +2819,12 @@ void BufferViewer::exportData(const BufferExport ¶ms) QString filter; if(params.format == BufferExport::CSV) - filter = lit("CSV Files (*.csv)"); + filter = tr("CSV Files (*.csv)"); else if(params.format == BufferExport::RawBytes) - filter = lit("Binary Files (*.bin)"); + filter = tr("Binary Files (*.bin)"); QString filename = RDDialog::getSaveFileName(this, tr("Export buffer to bytes"), QString(), - QFormatStr("%1;;All files (*.*)").arg(filter)); + tr("%1;;All files (*.*)").arg(filter)); if(filename.isEmpty()) return; diff --git a/qrenderdoc/Windows/Dialogs/CaptureDialog.cpp b/qrenderdoc/Windows/Dialogs/CaptureDialog.cpp index fd060a264..5bf65d2f0 100644 --- a/qrenderdoc/Windows/Dialogs/CaptureDialog.cpp +++ b/qrenderdoc/Windows/Dialogs/CaptureDialog.cpp @@ -472,7 +472,7 @@ void CaptureDialog::on_toggleGlobal_clicked() void CaptureDialog::on_saveSettings_clicked() { QString filename = RDDialog::getSaveFileName(this, tr("Save Settings As"), QString(), - lit("Capture settings (*.cap)")); + tr("Capture settings (*.cap)")); if(!filename.isEmpty()) { @@ -488,7 +488,7 @@ void CaptureDialog::on_saveSettings_clicked() void CaptureDialog::on_loadSettings_clicked() { QString filename = RDDialog::getOpenFileName(this, tr("Open Settings"), QString(), - lit("Capture settings (*.cap)")); + tr("Capture settings (*.cap)")); if(!filename.isEmpty() && QFileInfo::exists(filename)) { diff --git a/qrenderdoc/Windows/EventBrowser.cpp b/qrenderdoc/Windows/EventBrowser.cpp index 9767660f6..346fbb078 100644 --- a/qrenderdoc/Windows/EventBrowser.cpp +++ b/qrenderdoc/Windows/EventBrowser.cpp @@ -479,7 +479,7 @@ void EventBrowser::on_stepPrev_clicked() void EventBrowser::on_exportDraws_clicked() { QString filename = - RDDialog::getSaveFileName(this, tr("Save Event List"), QString(), lit("Text files (*.txt)")); + RDDialog::getSaveFileName(this, tr("Save Event List"), QString(), tr("Text files (*.txt)")); if(!filename.isEmpty()) {