From 88879dd34944a71950a55693b8bbcf1ec59d76d7 Mon Sep 17 00:00:00 2001 From: baldurk Date: Tue, 12 Nov 2019 08:35:54 +0000 Subject: [PATCH] Disable compute support on GL < 4.2. Closes #1591 --- renderdoc/driver/gl/gl_common.cpp | 6 ++++++ renderdoc/driver/gl/gl_debug.cpp | 7 ------- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/renderdoc/driver/gl/gl_common.cpp b/renderdoc/driver/gl/gl_common.cpp index 63a93faf0..8c4913550 100644 --- a/renderdoc/driver/gl/gl_common.cpp +++ b/renderdoc/driver/gl/gl_common.cpp @@ -474,6 +474,12 @@ void FetchEnabledExtensions() HasExt[ARB_program_interface_query] = false; } + + if(!IsGLES && GLCoreVersion < 42 && HasExt[ARB_compute_shader]) + { + RDCERR("GL implementation has ARB_compute_shader but is not at least 4.2. Disabling compute."); + HasExt[ARB_compute_shader] = false; + } } void DoVendorChecks(GLPlatform &platform, GLWindowingData context) diff --git a/renderdoc/driver/gl/gl_debug.cpp b/renderdoc/driver/gl/gl_debug.cpp index daec001a7..3a9205127 100644 --- a/renderdoc/driver/gl/gl_debug.cpp +++ b/renderdoc/driver/gl/gl_debug.cpp @@ -762,13 +762,6 @@ void GLReplay::InitDebugData() RenderDoc::Inst().SetProgress(LoadProgress::DebugManagerInit, 0.6f); - if(HasExt[ARB_compute_shader] && !HasExt[ARB_shading_language_420pack]) - { - RDCERR( - "GL implementation has ARB_compute_shader but not ARB_shading_language_420pack! " - "Compute shaders won't compile successfully."); - } - // histogram/minmax data { RDCEraseEl(DebugData.minmaxTileProgram);