From 8e423f4c769cc98152ae2bb13f290d340947924a Mon Sep 17 00:00:00 2001 From: baldurk Date: Fri, 9 Jun 2017 17:00:44 +0100 Subject: [PATCH] Add some parameter checking to the capture context interface --- qrenderdoc/Code/CaptureContext.cpp | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/qrenderdoc/Code/CaptureContext.cpp b/qrenderdoc/Code/CaptureContext.cpp index 14ae5a2fc..758453598 100644 --- a/qrenderdoc/Code/CaptureContext.cpp +++ b/qrenderdoc/Code/CaptureContext.cpp @@ -921,6 +921,11 @@ void CaptureContext::RaiseDockWindow(QWidget *dockWindow) void CaptureContext::AddDockWindow(QWidget *newWindow, DockReference ref, QWidget *refWindow, float percentage) { + if(!newWindow) + { + qCritical() << "Unexpected NULL newWindow in AddDockWindow"; + return; + } setupDockWindow(newWindow); if(ref == DockReference::MainToolArea) @@ -933,6 +938,13 @@ void CaptureContext::AddDockWindow(QWidget *newWindow, DockReference ref, QWidge m_MainWindow->mainToolManager()->addToolWindow(newWindow, m_MainWindow->leftToolArea()); return; } + + if(!refWindow) + { + qCritical() << "Unexpected NULL refWindow in AddDockWindow"; + return; + } + if(ref == DockReference::ConstantBufferArea) { if(ConstantBufferPreviewer::getOne())