From 8f0e1de6694348bcc9a7d934d7467aaf6128e664 Mon Sep 17 00:00:00 2001 From: baldurk Date: Thu, 24 Jun 2021 16:55:02 +0100 Subject: [PATCH] Don't write to pNext pointers in SerialiseNext() when writing * These pNext pointers might be in read-only memory so it would cause an exception, and nothing has changed so there's no need. --- renderdoc/driver/vulkan/vk_serialise.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/renderdoc/driver/vulkan/vk_serialise.cpp b/renderdoc/driver/vulkan/vk_serialise.cpp index 106ebfc35..ab7624f71 100644 --- a/renderdoc/driver/vulkan/vk_serialise.cpp +++ b/renderdoc/driver/vulkan/vk_serialise.cpp @@ -1482,7 +1482,8 @@ static void SerialiseNext(SerialiserType &ser, VkStructureType &sType, void *&pN { const void *tmpNext = pNext; SerialiseNext(ser, sType, tmpNext); - pNext = (void *)tmpNext; + if(ser.IsReading()) + pNext = (void *)tmpNext; } static inline void DeserialiseNext(const void *pNext)