From 9548f74f168ef755b875203ffd1541fda269f240 Mon Sep 17 00:00:00 2001 From: baldurk Date: Fri, 2 Mar 2018 14:31:01 +0000 Subject: [PATCH] Only set ShaderEditing analytic bit when saving, not first editing * This means if someone just clicks to edit but doesn't actually edit, won't register as having used the feature. --- qrenderdoc/Windows/PipelineState/PipelineStateViewer.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qrenderdoc/Windows/PipelineState/PipelineStateViewer.cpp b/qrenderdoc/Windows/PipelineState/PipelineStateViewer.cpp index 60617c42c..9ab8b39d5 100644 --- a/qrenderdoc/Windows/PipelineState/PipelineStateViewer.cpp +++ b/qrenderdoc/Windows/PipelineState/PipelineStateViewer.cpp @@ -717,8 +717,6 @@ void PipelineStateViewer::EditShader(ShaderStage shaderType, ResourceId id, const ShaderReflection *shaderDetails, const QString &entryFunc, const rdcstrpairs &files) { - ANALYTIC_SET(UIFeatures.ShaderEditing, true); - IShaderViewer *sv = m_Ctx.EditShader( false, entryFunc, files, // save callback @@ -726,6 +724,8 @@ void PipelineStateViewer::EditShader(ShaderStage shaderType, ResourceId id, const rdcstrpairs &updatedfiles) { QString compileSource = updatedfiles[0].second; + ANALYTIC_SET(UIFeatures.ShaderEditing, true); + // try and match up #includes against the files that we have. This isn't always // possible as fxc only seems to include the source for files if something in // that file was included in the compiled output. So you might end up with