From 98f2ad00e638c20c651a94cd37b985b001a679b4 Mon Sep 17 00:00:00 2001 From: baldurk Date: Fri, 9 Jun 2023 15:04:22 +0100 Subject: [PATCH] Don't free StreamWriter buffer until after callbacks * Some callbacks may want to process the data so we can't free it out from under them. --- renderdoc/serialise/streamio.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/renderdoc/serialise/streamio.cpp b/renderdoc/serialise/streamio.cpp index 231b38984..ecdded633 100644 --- a/renderdoc/serialise/streamio.cpp +++ b/renderdoc/serialise/streamio.cpp @@ -771,8 +771,6 @@ StreamWriter::StreamWriter(Compressor *compressor, Ownership own) StreamWriter::~StreamWriter() { - FreeAlignedBuffer(m_BufferBase); - if(m_Ownership == Ownership::Stream) { if(m_File) @@ -789,6 +787,8 @@ StreamWriter::~StreamWriter() for(StreamCloseCallback cb : m_Callbacks) cb(); + + FreeAlignedBuffer(m_BufferBase); } bool StreamWriter::SendSocketData(const void *data, uint64_t numBytes)