From 99b7f529b6d2cd9eede09ee8d193efc9d6bd9ce7 Mon Sep 17 00:00:00 2001 From: baldurk Date: Sat, 25 Jul 2015 20:12:26 +0200 Subject: [PATCH] Fix range bounds check being set up wrongly in shader debug. Refs #143 * The offset is independent of checking the index against the number of elements in the view. Otherwise e.g. offset=5 and numelems=1 would never be in bounds. --- renderdoc/driver/shaders/dxbc/dxbc_debug.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/renderdoc/driver/shaders/dxbc/dxbc_debug.cpp b/renderdoc/driver/shaders/dxbc/dxbc_debug.cpp index 6b13a1305..13ed4d3c3 100644 --- a/renderdoc/driver/shaders/dxbc/dxbc_debug.cpp +++ b/renderdoc/driver/shaders/dxbc/dxbc_debug.cpp @@ -2255,7 +2255,7 @@ State State::GetNext(GlobalState &global, State quad[4]) const } if(!data || - (!texData && offset + elemIdx >= numElems) || + (!texData && elemIdx >= numElems) || (texData && texOffset >= global.uavs[resIndex].data.size()) ) {