lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-09-27 08:05:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add safety to satisfy Coverity on some errors that are likely impossible

Browse Source 
* Reported by Coverity Scan
This commit is contained in:
baldurk
2017-11-22 19:11:14 +00:00
parent 25ea14c965
commit 9e5cfa8b96
15 changed files with 142 additions and 94 deletions
Download Patch File Download Diff File Expand all files Collapse all files
qrenderdoc/Windows/Dialogs/EnvironmentEditor.cpp
+6 -1
View File
@@ -170,7 +170,12 @@ void EnvironmentEditor::on_deleteButton_clicked()
if(!sel)
return;
delete ui->variables->takeTopLevelItem(ui->variables->indexOfTopLevelItem(sel));
int idx = ui->variables->indexOfTopLevelItem(sel);
if(idx >= 0)
delete ui->variables->takeTopLevelItem(idx);
else
qCritical() << "Can't find item to delete";
on_name_textChanged(ui->name->text());
}
qrenderdoc/Windows/Dialogs/RemoteManager.cpp
+4 -2
View File
@@ -640,8 +640,10 @@ void RemoteManager::on_deleteHost_clicked()
RemoteHost *host = getRemoteHost(item);
int itemIdx = ui->hosts->indexOfTopLevelItem(item);
// don't delete running instances on a host
if(item->parent() != ui->hosts->invisibleRootItem() || !host)
if(item->parent() != ui->hosts->invisibleRootItem() || itemIdx < 0 || !host)
return;
QString hostname = item->text(0);
@@ -664,7 +666,7 @@ void RemoteManager::on_deleteHost_clicked()
item->clear();
queueDelete(ui->hosts->takeTopLevelItem(ui->hosts->indexOfTopLevelItem(item)));
queueDelete(ui->hosts->takeTopLevelItem(itemIdx));
ui->hosts->clearSelection();