From a253f01bb27a7bf3dee2b2722035627b2a267339 Mon Sep 17 00:00:00 2001 From: baldurk Date: Thu, 20 May 2021 17:11:59 +0100 Subject: [PATCH] Add some bullet-proofing against invalid model indices --- qrenderdoc/Windows/EventBrowser.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/qrenderdoc/Windows/EventBrowser.cpp b/qrenderdoc/Windows/EventBrowser.cpp index b5fce70ef..b3e42f7c8 100644 --- a/qrenderdoc/Windows/EventBrowser.cpp +++ b/qrenderdoc/Windows/EventBrowser.cpp @@ -439,6 +439,9 @@ struct EventItemModel : public QAbstractItemModel if(index.internalId() == TagCaptureStart) return createIndex(0, 0, TagRoot); + if(index.internalId() >= m_Draws.size()) + return QModelIndex(); + // otherwise it's a draw const DrawcallDescription *draw = m_Draws[index.internalId()]; @@ -559,6 +562,9 @@ struct EventItemModel : public QAbstractItemModel { uint32_t eid = index.internalId(); + if(eid >= m_Draws.size()) + return QVariant(); + if(role == ROLE_SELECTED_EID) return eid;