From a4fd53af8fab05ca601ec6997d9c631bddd5141b Mon Sep 17 00:00:00 2001 From: baldurk Date: Thu, 21 Jan 2021 11:28:23 +0000 Subject: [PATCH] Fix a crash if capture viewers are changed while processing SetEvent * This could happen in particular now that thumbnails are capture viewers. --- qrenderdoc/Code/CaptureContext.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/qrenderdoc/Code/CaptureContext.cpp b/qrenderdoc/Code/CaptureContext.cpp index cd344aa68..84fd19953 100644 --- a/qrenderdoc/Code/CaptureContext.cpp +++ b/qrenderdoc/Code/CaptureContext.cpp @@ -1591,9 +1591,11 @@ void CaptureContext::RefreshUIStatus(const rdcarray &exclude, PointerTypeRegistry::CacheShader(refl); } - for(ICaptureViewer *viewer : m_CaptureViewers) + rdcarray capviewers(m_CaptureViewers); + + for(ICaptureViewer *viewer : capviewers) { - if(exclude.contains(viewer)) + if(!viewer || exclude.contains(viewer) || !m_CaptureViewers.contains(viewer)) continue; if(updateSelectedEvent)