From b47fedf08cb1f24a83d923f7bddf5656ac898a7b Mon Sep 17 00:00:00 2001 From: baldurk Date: Sat, 17 Jan 2015 13:06:04 +0000 Subject: [PATCH] Remove a couple of TODOs from GL driver * GL_MIN_MAP_BUFFER_ALIGNMENT is now satisfied (up to 64), and from reading the spec, yes the mip dimensions have to be defined as standard, you can't define just some crazy custom mip chain sizes as that's invalid. --- renderdoc/driver/gl/gl_replay.cpp | 1 - renderdoc/driver/gl/wrappers/gl_buffer_funcs.cpp | 2 -- 2 files changed, 3 deletions(-) diff --git a/renderdoc/driver/gl/gl_replay.cpp b/renderdoc/driver/gl/gl_replay.cpp index d8864953c..9cd1a9fdb 100644 --- a/renderdoc/driver/gl/gl_replay.cpp +++ b/renderdoc/driver/gl/gl_replay.cpp @@ -431,7 +431,6 @@ void GLReplay::CacheTexture(ResourceId id) if(levelQueryType == eGL_TEXTURE_CUBE_MAP) levelQueryType = eGL_TEXTURE_CUBE_MAP_POSITIVE_X; - // TODO if I call this for levels 1, 2, .. etc. Can I get sizes that aren't mip dimensions? GLint width = 1, height = 1, depth = 1, samples=1; gl.glGetTextureLevelParameterivEXT(res.resource.name, levelQueryType, 0, eGL_TEXTURE_WIDTH, &width); gl.glGetTextureLevelParameterivEXT(res.resource.name, levelQueryType, 0, eGL_TEXTURE_HEIGHT, &height); diff --git a/renderdoc/driver/gl/wrappers/gl_buffer_funcs.cpp b/renderdoc/driver/gl/wrappers/gl_buffer_funcs.cpp index ee8e7ede6..7bea1607c 100644 --- a/renderdoc/driver/gl/wrappers/gl_buffer_funcs.cpp +++ b/renderdoc/driver/gl/wrappers/gl_buffer_funcs.cpp @@ -1280,8 +1280,6 @@ void *WrappedOpenGL::glMapNamedBufferEXT(GLuint buffer, GLenum access) return record->Map.ptr; } - // TODO align return pointer to GL_MIN_MAP_BUFFER_ALIGNMENT (min 64) - if(access == eGL_READ_ONLY) { record->Map.status = GLResourceRecord::Mapped_Read_Real;