From b52d91224e5e44867c42c97cf2009af9e566c9c4 Mon Sep 17 00:00:00 2001 From: Cody Northrop Date: Mon, 14 Aug 2017 13:49:20 -0600 Subject: [PATCH] utils: Update messageBoxChecked to use bool directly, no local copy --- qrenderdoc/Code/QRDUtils.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/qrenderdoc/Code/QRDUtils.cpp b/qrenderdoc/Code/QRDUtils.cpp index 22205a49b..5f3a596fc 100644 --- a/qrenderdoc/Code/QRDUtils.cpp +++ b/qrenderdoc/Code/QRDUtils.cpp @@ -448,7 +448,6 @@ QMessageBox::StandardButton RDDialog::messageBoxChecked(QMessageBox::Icon icon, QMessageBox::StandardButtons buttons, QMessageBox::StandardButton defaultButton) { - bool isChecked = checked; QMessageBox::StandardButton ret = defaultButton; // if we're already on the right thread, this boils down to a function call @@ -457,11 +456,10 @@ QMessageBox::StandardButton RDDialog::messageBoxChecked(QMessageBox::Icon icon, mb.setDefaultButton(defaultButton); mb.setCheckBox(checkBox); show(&mb); - isChecked = mb.checkBox()->isChecked(); + checked = mb.checkBox()->isChecked(); ret = mb.standardButton(mb.clickedButton()); }); - checked = isChecked; return ret; }