From b843c38bdcd5d823b85263f9611371a69a4b79e2 Mon Sep 17 00:00:00 2001 From: baldurk Date: Wed, 9 Nov 2016 19:27:44 +0100 Subject: [PATCH] Categorise remaining TODOs somewhat --- qrenderdoc/Code/CaptureContext.cpp | 2 +- qrenderdoc/Code/RenderManager.cpp | 2 +- qrenderdoc/Code/RenderManager.h | 16 ++++++++-------- qrenderdoc/Windows/Dialogs/CaptureDialog.cpp | 6 +++--- qrenderdoc/Windows/Dialogs/TextureSaveDialog.cpp | 9 ++++----- qrenderdoc/Windows/MainWindow.cpp | 12 ++++++------ qrenderdoc/Windows/TextureViewer.cpp | 12 ++++++------ 7 files changed, 29 insertions(+), 30 deletions(-) diff --git a/qrenderdoc/Code/CaptureContext.cpp b/qrenderdoc/Code/CaptureContext.cpp index 2f54218e8..1a8cf308f 100644 --- a/qrenderdoc/Code/CaptureContext.cpp +++ b/qrenderdoc/Code/CaptureContext.cpp @@ -172,7 +172,7 @@ void CaptureContext::LoadLogfileThreaded(const QString &logFile, const QString & { QString errmsg = "Unknown error message"; - // TODO + // TODO ToStr // errmsg = m_Renderer.GetCreateStatus(); progressThread.acquire(); diff --git a/qrenderdoc/Code/RenderManager.cpp b/qrenderdoc/Code/RenderManager.cpp index 0e6e7b583..0c107e531 100644 --- a/qrenderdoc/Code/RenderManager.cpp +++ b/qrenderdoc/Code/RenderManager.cpp @@ -71,7 +71,7 @@ void RenderManager::DeleteCapture(const QString &logfile, bool local) } else { - // TODO + // TODO Remote // m_Remote.TakeOwnershipCapture(logfile); } } diff --git a/qrenderdoc/Code/RenderManager.h b/qrenderdoc/Code/RenderManager.h index 9caa28b92..f270e4798 100644 --- a/qrenderdoc/Code/RenderManager.h +++ b/qrenderdoc/Code/RenderManager.h @@ -54,9 +54,9 @@ struct EnvironmentModification QString ret; if(type == eEnvMod_Append) - ret = QString("Append, %1").arg("TODO"); + ret = QString("Append, %1").arg("TODO ToStr"); else if(type == eEnvMod_Prepend) - ret = QString("Prepend, %1").arg("TODO"); + ret = QString("Prepend, %1").arg("TODO ToStr"); else ret = "Set"; @@ -68,9 +68,9 @@ struct EnvironmentModification QString ret; if(type == eEnvMod_Append) - ret = QString("Append %1 with %2 using %3").arg(variable).arg(value).arg("TODO"); + ret = QString("Append %1 with %2 using %3").arg(variable).arg(value).arg("TODO ToStr"); else if(type == eEnvMod_Prepend) - ret = QString("Prepend %1 with %2 using %3").arg(variable).arg(value).arg("TODO"); + ret = QString("Prepend %1 with %2 using %3").arg(variable).arg(value).arg("TODO ToStr"); else ret = QString("Set %1 to %2").arg(variable).arg(value); @@ -82,8 +82,8 @@ struct EnvironmentModification QVariantMap ret; ret["variable"] = variable; ret["value"] = value; - ret["type"] = "Append"; // TODO - ret["separator"] = "Semi-colon"; // TODO + ret["type"] = "Append"; // TODO ToStr + ret["separator"] = "Semi-colon"; // TODO ToStr return ret; } @@ -91,8 +91,8 @@ struct EnvironmentModification { variable = data["variable"].toString(); value = data["value"].toString(); - type = eEnvMod_Append; // TODO - separator = eEnvSep_SemiColon; // TODO + type = eEnvMod_Append; // TODO ToStr + separator = eEnvSep_SemiColon; // TODO ToStr } }; diff --git a/qrenderdoc/Windows/Dialogs/CaptureDialog.cpp b/qrenderdoc/Windows/Dialogs/CaptureDialog.cpp index 3e4804b70..6f6220179 100644 --- a/qrenderdoc/Windows/Dialogs/CaptureDialog.cpp +++ b/qrenderdoc/Windows/Dialogs/CaptureDialog.cpp @@ -151,7 +151,7 @@ CaptureDialog::CaptureDialog(CaptureContext *ctx, OnCaptureMethod captureCallbac // sort by PID by default ui->processList->sortByColumn(1, Qt::AscendingOrder); - // TODO + // TODO Vulkan Layer ui->vulkanLayerWarn->setVisible(true); m_CaptureCallback = captureCallback; @@ -239,7 +239,7 @@ void CaptureDialog::on_exePath_textChanged(const QString &exe) void CaptureDialog::on_vulkanCapture_clicked() { - // TODO + // TODO Vulkan Layer } void CaptureDialog::on_processRefesh_clicked() @@ -324,7 +324,7 @@ void CaptureDialog::on_workDirBrowse_clicked() void CaptureDialog::on_envVarEdit_clicked() { - // TODO + // TODO Env Editor } void CaptureDialog::on_toggleGlobal_clicked() diff --git a/qrenderdoc/Windows/Dialogs/TextureSaveDialog.cpp b/qrenderdoc/Windows/Dialogs/TextureSaveDialog.cpp index 452891134..f878f19ff 100644 --- a/qrenderdoc/Windows/Dialogs/TextureSaveDialog.cpp +++ b/qrenderdoc/Windows/Dialogs/TextureSaveDialog.cpp @@ -37,8 +37,7 @@ TextureSaveDialog::TextureSaveDialog(const FetchTexture &t, const TextureSave &s ui->fileFormat->clear(); - // TODO - + // TODO ToStr ui->fileFormat->addItems({"DDS", "PNG", "JPG", "BMP", "TGA", "HDR", "EXR"}); ui->alphaMap->addItems({"Discard", "Blend to Colour", "Blend to Checkerboard"}); @@ -131,7 +130,7 @@ void TextureSaveDialog::SetFiletypeFromFilename() QFileInfo path(ui->filename->text()); QString ext = path.suffix().toUpper(); - // TODO + // TODO ToStr /* foreach(var ft in(FileType[])Enum.GetValues(typeof(FileType))) @@ -150,7 +149,7 @@ void TextureSaveDialog::SetFilenameFromFiletype() QFileInfo path(ui->filename->text()); QString ext = path.suffix().toUpper(); - // TODO + // TODO ToStr /* FileType[] types = (FileType[])Enum.GetValues(typeof(FileType)); @@ -489,7 +488,7 @@ void TextureSaveDialog::on_whitePoint_textEdited(const QString &arg) void TextureSaveDialog::on_browse_clicked() { - QString filter = "TODO"; + QString filter = "TODO ToStr"; QString *selectedFilter = NULL; QString filename = diff --git a/qrenderdoc/Windows/MainWindow.cpp b/qrenderdoc/Windows/MainWindow.cpp index a205f1d25..e2a924ae8 100644 --- a/qrenderdoc/Windows/MainWindow.cpp +++ b/qrenderdoc/Windows/MainWindow.cpp @@ -494,7 +494,7 @@ bool MainWindow::PromptSaveLog() } else { - // TODO + // TODO Remote // m_Core.Renderer.CopyCaptureFromRemote(m_Core.LogFileName, saveFilename, this); } @@ -599,13 +599,13 @@ void MainWindow::SetTitle(const QString &filename) prefix += " - "; } - // TODO + // TODO Remote // if(m_Ctx != NULL && m_Ctx->Renderer.Remote != null) // prefix += String.Format("Remote: {0} - ", m_Core.Renderer.Remote.Hostname); QString text = prefix + "RenderDoc "; - // TODO + // TODO Versioning /* if(OfficialVersion) text += VersionString; @@ -615,7 +615,7 @@ void MainWindow::SetTitle(const QString &filename) text += tr("Unofficial release (%1 - %2)").arg(RENDERDOC_GetVersionString()).arg(RENDERDOC_GetCommitHash()); - // TODO + // TODO Versioning // if(IsVersionMismatched()) // text += " - !! VERSION MISMATCH DETECTED !!"; @@ -725,7 +725,7 @@ void MainWindow::setProgress(float val) void MainWindow::OnLogfileLoaded() { - // TODO + // TODO Remote // don't allow changing context while log is open // contextChooser.Enabled = false; @@ -766,7 +766,7 @@ void MainWindow::OnLogfileClosed() SetTitle(); // if the remote sever disconnected during log replay, resort back to a 'disconnected' state - // TODO + // TODO Remote /* if(m_Core.Renderer.Remote != null && !m_Core.Renderer.Remote.ServerRunning) { diff --git a/qrenderdoc/Windows/TextureViewer.cpp b/qrenderdoc/Windows/TextureViewer.cpp index c8283a6d2..84c00765b 100644 --- a/qrenderdoc/Windows/TextureViewer.cpp +++ b/qrenderdoc/Windows/TextureViewer.cpp @@ -1000,7 +1000,7 @@ void TextureViewer::UI_UpdateTextureDetails() if(current.format.compType != m_TexDisplay.typeHint && m_TexDisplay.typeHint != eCompType_None) { - status += tr(" Viewed as TODO"); // m_TexDisplay.typeHint.Str(); + status += tr(" Viewed as TODO ToStr"); // m_TexDisplay.typeHint.Str(); } ui->texStatusDim->setText(status); @@ -1288,7 +1288,7 @@ void TextureViewer::UI_OnTextureSelectionChanged(bool newdraw) if(m_Output != NULL) RT_PickPixelsAndUpdate(r); - // TODO - GetUsage and update TimelineBar + // TODO TimelineBar }); } @@ -1747,12 +1747,12 @@ void TextureViewer::AddResourceUsageEntry(QMenu &menu, uint32_t start, uint32_t QAction *item = NULL; if(start == end) - item = new QAction( - "EID " + QString::number(start) + ": " + "TODO" /*usage.Str(m_Core.APIProps.pipelineType)*/, - this); + item = new QAction("EID " + QString::number(start) + ": " + + "TODO ToStr" /*usage.Str(m_Core.APIProps.pipelineType)*/, + this); else item = new QAction("EID " + QString::number(start) + "-" + QString::number(end) + ": " + - "TODO" /*usage.Str(m_Core.APIProps.pipelineType)*/, + "TODO ToStr" /*usage.Str(m_Core.APIProps.pipelineType)*/, this); QObject::connect(item, &QAction::triggered, this, &TextureViewer::texContextItem_triggered);