From b857463968cc034134155ee894372d21f9e14335 Mon Sep 17 00:00:00 2001 From: nachocpol Date: Mon, 3 Aug 2026 09:29:56 +0200 Subject: [PATCH] Feedback from PR --- renderdoc/driver/shaders/dxil/dxil_bytecode.cpp | 4 ++-- renderdoc/driver/shaders/dxil/dxil_bytecode_editor.cpp | 2 +- renderdoc/driver/shaders/dxil/llvm_common.h | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/renderdoc/driver/shaders/dxil/dxil_bytecode.cpp b/renderdoc/driver/shaders/dxil/dxil_bytecode.cpp index 15624da3d..ae01e093a 100644 --- a/renderdoc/driver/shaders/dxil/dxil_bytecode.cpp +++ b/renderdoc/driver/shaders/dxil/dxil_bytecode.cpp @@ -236,8 +236,8 @@ void Program::ParseConstant(ValueList &values, const LLVMBC::BlockOrRecord &cons c->setCompound(alloc, std::move(members)); values.addValue(); } - else if(IS_KNOWN(constant.id, ConstantsRecord::EVAL_GEP) || - IS_KNOWN(constant.id, ConstantsRecord::EVAL_GEP_OLD)) + else if(IS_KNOWN(constant.id, ConstantsRecord::EVAL_INBOUNDS_GEP) || + IS_KNOWN(constant.id, ConstantsRecord::EVAL_GEP)) { Constant *c = values.nextValue(); diff --git a/renderdoc/driver/shaders/dxil/dxil_bytecode_editor.cpp b/renderdoc/driver/shaders/dxil/dxil_bytecode_editor.cpp index b770edba7..85e5fb6ef 100644 --- a/renderdoc/driver/shaders/dxil/dxil_bytecode_editor.cpp +++ b/renderdoc/driver/shaders/dxil/dxil_bytecode_editor.cpp @@ -1808,7 +1808,7 @@ void ProgramEditor::EncodeConstants(LLVMBC::BitcodeWriter &writer, vals.push_back(getValueID(c->getMembers()[m])); } - writer.Record(LLVMBC::ConstantsRecord::EVAL_GEP, vals); + writer.Record(LLVMBC::ConstantsRecord::EVAL_INBOUNDS_GEP, vals); } else if(IsCast(c->op)) { diff --git a/renderdoc/driver/shaders/dxil/llvm_common.h b/renderdoc/driver/shaders/dxil/llvm_common.h index 106679545..0be4b42ca 100644 --- a/renderdoc/driver/shaders/dxil/llvm_common.h +++ b/renderdoc/driver/shaders/dxil/llvm_common.h @@ -111,8 +111,8 @@ enum class ConstantsRecord : uint32_t CSTRING = 9, EVAL_BINOP = 10, EVAL_CAST = 11, - EVAL_GEP_OLD = 12, - EVAL_GEP = 20, + EVAL_GEP = 12, + EVAL_INBOUNDS_GEP = 20, DATA = 22, };