From b8cee9f530a57536dfe19c15fc590d9f1b613ae5 Mon Sep 17 00:00:00 2001 From: baldurk Date: Sat, 29 Oct 2016 21:28:27 +0200 Subject: [PATCH] Add missing break statements, thanks to report from @RCalocaO! --- .../driver/shaders/dxbc/dxbc_inspect.cpp | 40 +++++++++++++------ 1 file changed, 28 insertions(+), 12 deletions(-) diff --git a/renderdoc/driver/shaders/dxbc/dxbc_inspect.cpp b/renderdoc/driver/shaders/dxbc/dxbc_inspect.cpp index a8e1a67cd..406ca0ca2 100644 --- a/renderdoc/driver/shaders/dxbc/dxbc_inspect.cpp +++ b/renderdoc/driver/shaders/dxbc/dxbc_inspect.cpp @@ -1086,20 +1086,28 @@ void DXBCFile::GuessResources() switch(dcl.dim) { - case RESOURCE_DIMENSION_BUFFER: desc.dimension = ShaderInputBind::DIM_BUFFER; - case RESOURCE_DIMENSION_TEXTURE1D: desc.dimension = ShaderInputBind::DIM_TEXTURE1D; - case RESOURCE_DIMENSION_TEXTURE2D: desc.dimension = ShaderInputBind::DIM_TEXTURE2D; - case RESOURCE_DIMENSION_TEXTURE3D: desc.dimension = ShaderInputBind::DIM_TEXTURE3D; - case RESOURCE_DIMENSION_TEXTURECUBE: desc.dimension = ShaderInputBind::DIM_TEXTURECUBE; + case RESOURCE_DIMENSION_BUFFER: desc.dimension = ShaderInputBind::DIM_BUFFER; break; + case RESOURCE_DIMENSION_TEXTURE1D: desc.dimension = ShaderInputBind::DIM_TEXTURE1D; break; + case RESOURCE_DIMENSION_TEXTURE2D: desc.dimension = ShaderInputBind::DIM_TEXTURE2D; break; + case RESOURCE_DIMENSION_TEXTURE3D: desc.dimension = ShaderInputBind::DIM_TEXTURE3D; break; + case RESOURCE_DIMENSION_TEXTURECUBE: + desc.dimension = ShaderInputBind::DIM_TEXTURECUBE; + break; case RESOURCE_DIMENSION_TEXTURE1DARRAY: desc.dimension = ShaderInputBind::DIM_TEXTURE1DARRAY; + break; case RESOURCE_DIMENSION_TEXTURE2DARRAY: desc.dimension = ShaderInputBind::DIM_TEXTURE2DARRAY; + break; case RESOURCE_DIMENSION_TEXTURECUBEARRAY: desc.dimension = ShaderInputBind::DIM_TEXTURECUBEARRAY; - case RESOURCE_DIMENSION_TEXTURE2DMS: desc.dimension = ShaderInputBind::DIM_TEXTURE2DMS; + break; + case RESOURCE_DIMENSION_TEXTURE2DMS: + desc.dimension = ShaderInputBind::DIM_TEXTURE2DMS; + break; case RESOURCE_DIMENSION_TEXTURE2DMSARRAY: desc.dimension = ShaderInputBind::DIM_TEXTURE2DMSARRAY; + break; default: desc.dimension = ShaderInputBind::DIM_UNKNOWN; break; } desc.numSamples = dcl.sampleCount; @@ -1246,20 +1254,28 @@ void DXBCFile::GuessResources() switch(dcl.dim) { - case RESOURCE_DIMENSION_BUFFER: desc.dimension = ShaderInputBind::DIM_BUFFER; - case RESOURCE_DIMENSION_TEXTURE1D: desc.dimension = ShaderInputBind::DIM_TEXTURE1D; - case RESOURCE_DIMENSION_TEXTURE2D: desc.dimension = ShaderInputBind::DIM_TEXTURE2D; - case RESOURCE_DIMENSION_TEXTURE3D: desc.dimension = ShaderInputBind::DIM_TEXTURE3D; - case RESOURCE_DIMENSION_TEXTURECUBE: desc.dimension = ShaderInputBind::DIM_TEXTURECUBE; + case RESOURCE_DIMENSION_BUFFER: desc.dimension = ShaderInputBind::DIM_BUFFER; break; + case RESOURCE_DIMENSION_TEXTURE1D: desc.dimension = ShaderInputBind::DIM_TEXTURE1D; break; + case RESOURCE_DIMENSION_TEXTURE2D: desc.dimension = ShaderInputBind::DIM_TEXTURE2D; break; + case RESOURCE_DIMENSION_TEXTURE3D: desc.dimension = ShaderInputBind::DIM_TEXTURE3D; break; + case RESOURCE_DIMENSION_TEXTURECUBE: + desc.dimension = ShaderInputBind::DIM_TEXTURECUBE; + break; case RESOURCE_DIMENSION_TEXTURE1DARRAY: desc.dimension = ShaderInputBind::DIM_TEXTURE1DARRAY; + break; case RESOURCE_DIMENSION_TEXTURE2DARRAY: desc.dimension = ShaderInputBind::DIM_TEXTURE2DARRAY; + break; case RESOURCE_DIMENSION_TEXTURECUBEARRAY: desc.dimension = ShaderInputBind::DIM_TEXTURECUBEARRAY; - case RESOURCE_DIMENSION_TEXTURE2DMS: desc.dimension = ShaderInputBind::DIM_TEXTURE2DMS; + break; + case RESOURCE_DIMENSION_TEXTURE2DMS: + desc.dimension = ShaderInputBind::DIM_TEXTURE2DMS; + break; case RESOURCE_DIMENSION_TEXTURE2DMSARRAY: desc.dimension = ShaderInputBind::DIM_TEXTURE2DMSARRAY; + break; default: desc.dimension = ShaderInputBind::DIM_UNKNOWN; break; } desc.numSamples = (uint32_t)-1;