From bbe25464f01ed9a3f9c82ef30e2c1c296af7cb55 Mon Sep 17 00:00:00 2001 From: baldurk Date: Mon, 23 May 2016 19:04:07 +0200 Subject: [PATCH] Coverity: Fix newly added defects --- renderdoc/core/core.h | 2 +- renderdoc/driver/d3d11/d3d11_device.h | 5 +++-- renderdoc/driver/vulkan/vk_debug.cpp | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/renderdoc/core/core.h b/renderdoc/core/core.h index a19b12e1a..f5dca4c69 100644 --- a/renderdoc/core/core.h +++ b/renderdoc/core/core.h @@ -189,7 +189,7 @@ public: void RegisterShutdownFunction(ShutdownFunction func) { m_ShutdownFunctions.insert(func); } void SetReplayApp(bool replay) { m_Replay = replay; } bool IsReplayApp() const { return m_Replay; } - string GetConfigSetting(string name) { return m_ConfigSettings[name]; } + const string &GetConfigSetting(string name) { return m_ConfigSettings[name]; } void SetConfigSetting(string name, string value) { m_ConfigSettings[name] = value; } void BecomeReplayHost(volatile uint32_t &killReplay); diff --git a/renderdoc/driver/d3d11/d3d11_device.h b/renderdoc/driver/d3d11/d3d11_device.h index 0992b4cfc..fb3d739cb 100644 --- a/renderdoc/driver/d3d11/d3d11_device.h +++ b/renderdoc/driver/d3d11/d3d11_device.h @@ -133,7 +133,7 @@ struct DummyID3D11InfoQueue : public ID3D11InfoQueue { WrappedID3D11Device *m_pDevice; - DummyID3D11InfoQueue() {} + DummyID3D11InfoQueue() : m_pDevice(NULL) {} ////////////////////////////// // implement IUnknown HRESULT STDMETHODCALLTYPE QueryInterface(REFIID riid, void **ppvObject) { return E_NOINTERFACE; } @@ -232,7 +232,8 @@ struct DummyID3D11Debug : public ID3D11Debug { WrappedID3D11Device *m_pDevice; - DummyID3D11Debug() {} + DummyID3D11Debug() : m_pDevice(NULL) {} + ////////////////////////////// // implement IUnknown HRESULT STDMETHODCALLTYPE QueryInterface(REFIID riid, void **ppvObject) { return E_NOINTERFACE; } diff --git a/renderdoc/driver/vulkan/vk_debug.cpp b/renderdoc/driver/vulkan/vk_debug.cpp index d717ed2aa..e8d777b04 100644 --- a/renderdoc/driver/vulkan/vk_debug.cpp +++ b/renderdoc/driver/vulkan/vk_debug.cpp @@ -66,7 +66,7 @@ void VulkanDebugManager::GPUBuffer::Create(WrappedVulkan *driver, VkDevice dev, VkResult vkr = driver->vkCreateBuffer(dev, &bufInfo, NULL, &buf); RDCASSERTEQUAL(vkr, VK_SUCCESS); - VkMemoryRequirements mrq; + VkMemoryRequirements mrq = {}; driver->vkGetBufferMemoryRequirements(dev, buf, &mrq); VkMemoryAllocateInfo allocInfo = {