From c3769ce569512b5d39943ea994f47ec40f4aafee Mon Sep 17 00:00:00 2001 From: baldurk Date: Thu, 18 Feb 2021 13:29:08 +0000 Subject: [PATCH] Remove tautological test summing empty array * We test above that the array is truly empty, if that passes the sum is superfluous. --- renderdoc/replay/basic_types_tests.cpp | 6 ------ 1 file changed, 6 deletions(-) diff --git a/renderdoc/replay/basic_types_tests.cpp b/renderdoc/replay/basic_types_tests.cpp index bb394d2a7..f5bdfccd6 100644 --- a/renderdoc/replay/basic_types_tests.cpp +++ b/renderdoc/replay/basic_types_tests.cpp @@ -154,12 +154,6 @@ TEST_CASE("Test array type", "[basictypes]") CHECK(test.isEmpty()); CHECK(test.begin() == test.end()); - sum = 0; - for(int x : test) - sum += x; - - CHECK(sum == 0); - test = {4, 1, 77, 0, 0, 8, 20, 934}; CHECK(test.size() == 8);