From c8b011344d300959bd768875f5a24f60db60caf0 Mon Sep 17 00:00:00 2001 From: Orson Baines Date: Fri, 24 Feb 2023 18:13:14 -0500 Subject: [PATCH] Remove feature toggle for OpenGL Pixel History --- docs/credits_acknowledgements.rst | 6 ++++++ renderdoc/driver/gl/gl_replay.cpp | 3 +-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/docs/credits_acknowledgements.rst b/docs/credits_acknowledgements.rst index 19b81bf2a..30c7f3ba0 100644 --- a/docs/credits_acknowledgements.rst +++ b/docs/credits_acknowledgements.rst @@ -192,6 +192,11 @@ There have been many people who have helped in the creation of RenderDoc. Whethe * Alex Kharlamov * Steve Karolewics * Kevin McCullough +* Ting Cai +* Zi Ming He +* Orson Baines +* John Kattukudiyil +* Tony Tascioglu Contributors ------------ @@ -206,3 +211,4 @@ The following list highlights notable open source contributions. Many other peop * Balazs Torok - Implemented the RenderDoc in-application overlay for D3D9. * Steve Karolewics - Implemented DXBC shader debugging support for D3D12. * Aliya Pazylbekova - Implemented pixel history support for Vulkan. +* Orson Baines, Zi Ming He, John Kattukudiyil, Ting Cai, Tony Tascioglu - Implemented pixel history support for OpenGL. diff --git a/renderdoc/driver/gl/gl_replay.cpp b/renderdoc/driver/gl/gl_replay.cpp index 75d78c297..a46fe018b 100644 --- a/renderdoc/driver/gl/gl_replay.cpp +++ b/renderdoc/driver/gl/gl_replay.cpp @@ -43,7 +43,6 @@ RDOC_CONFIG(bool, OpenGL_HardwareCounters, true, "Enable support for IHV-specific hardware counters on OpenGL."); -RDOC_CONFIG(bool, OpenGL_PixelHistory, false, "Enable Pixel History on OpenGL (WIP)."); static const char *SPIRVDisassemblyTarget = "SPIR-V (RenderDoc)"; @@ -224,7 +223,7 @@ APIProperties GLReplay::GetAPIProperties() ret.degraded = m_Degraded; ret.vendor = m_DriverInfo.vendor; ret.shadersMutable = true; - ret.pixelHistory = OpenGL_PixelHistory(); + ret.pixelHistory = true; return ret; }