From c9eeef3151579922e6049f50530936d1d732c585 Mon Sep 17 00:00:00 2001 From: baldurk Date: Wed, 14 Sep 2016 17:41:14 +0200 Subject: [PATCH] [Coverity] Add proper NULL check before comparison --- renderdoc/core/remote_server.cpp | 2 +- renderdoc/core/target_control.cpp | 2 +- renderdoc/replay/entry_points.cpp | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/renderdoc/core/remote_server.cpp b/renderdoc/core/remote_server.cpp index b26e5314c..ec9873a24 100644 --- a/renderdoc/core/remote_server.cpp +++ b/renderdoc/core/remote_server.cpp @@ -1187,7 +1187,7 @@ RENDERDOC_CreateRemoteServerConnection(const char *host, uint32_t port, RemoteSe if(host != NULL && host[0] != '\0') s = host; - if(!strncmp(host, "adb:", 4)) + if(host != NULL && !strncmp(host, "adb:", 4)) { s = "127.0.0.1"; diff --git a/renderdoc/core/target_control.cpp b/renderdoc/core/target_control.cpp index 538e3f18d..e8f5bfd48 100644 --- a/renderdoc/core/target_control.cpp +++ b/renderdoc/core/target_control.cpp @@ -707,7 +707,7 @@ extern "C" RENDERDOC_API TargetControl *RENDERDOC_CC RENDERDOC_CreateTargetContr bool android = false; - if(!strncmp(host, "adb:", 4)) + if(host != NULL && !strncmp(host, "adb:", 4)) { android = true; s = "127.0.0.1"; diff --git a/renderdoc/replay/entry_points.cpp b/renderdoc/replay/entry_points.cpp index 6d47f9322..c7fec8a56 100644 --- a/renderdoc/replay/entry_points.cpp +++ b/renderdoc/replay/entry_points.cpp @@ -477,7 +477,7 @@ extern "C" RENDERDOC_API uint32_t RENDERDOC_CC RENDERDOC_EnumerateRemoteTargets( if(host != NULL && host[0] != '\0') s = host; - if(!strncmp(host, "adb:", 4)) + if(host != NULL && !strncmp(host, "adb:", 4)) { s = "127.0.0.1";