From cdd731d00ca1238354101cc5d2d2e02a2a35828b Mon Sep 17 00:00:00 2001 From: baldurk Date: Fri, 22 Dec 2017 22:17:07 +0000 Subject: [PATCH] Add -Wl,--no-undefined to ensure all symbols are resolved * This prevents issues where perhaps some file that is compiled in references a symbol in another file which is not compiled or isn't enabled, leaving an undefined symbol in librenderdoc.so. This can lead to some seriously hard to track bugs. --- renderdoc/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/renderdoc/CMakeLists.txt b/renderdoc/CMakeLists.txt index 293890a0b..cd68daeea 100644 --- a/renderdoc/CMakeLists.txt +++ b/renderdoc/CMakeLists.txt @@ -369,7 +369,7 @@ target_include_directories(renderdoc ${RDOC_INCLUDES}) target_link_libraries(renderdoc ${RDOC_LIBRARIES}) if(UNIX AND NOT ANDROID AND NOT APPLE) - set_target_properties(renderdoc PROPERTIES LINK_FLAGS "-Wl,--version-script,${CMAKE_CURRENT_SOURCE_DIR}/renderdoc.version") + set_target_properties(renderdoc PROPERTIES LINK_FLAGS "-Wl,--version-script,${CMAKE_CURRENT_SOURCE_DIR}/renderdoc.version -Wl,--no-undefined") endif() if(ANDROID)