Revert behaviour with cull mode not affecting texture overlays

Browse Source

* This is kind of a "damned if you do, damned if you don't" situation. If the
  cullmode is wrong, having it show up as failures in depth/stencil overlays is
  misleading. However if the cullmode is deliberate setting it to no-cull may
  ruin the results of those overlays.
* The original behaviour of leaving cullmode as is ends up being a better
  tradeoff, since at least when it is misleading you can use the culling overlay
  to show the failure there. If culling is disabled it makes depth/stencil
  overlays useless in situations with no recourse.
* Also add a test of a depth-clipped triangle to overlay tests

...

This commit is contained in:

baldurk

2018-12-04 18:16:34 +00:00

parent 264b296b7d

commit d339874a06

61 changed files with 117 additions and 137 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

util/test/data/D3D12_Overlay_Test/DebugOverlay.BackfaceCull.png

BIN

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 1.2 KiB After Width:  |  Height:  |  Size: 1.2 KiB

util/test/data/D3D12_Overlay_Test/DebugOverlay.ClearBeforeDraw.png

BIN

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 2.1 KiB After Width:  |  Height:  |  Size: 2.2 KiB

util/test/data/D3D12_Overlay_Test/DebugOverlay.ClearBeforePass.png

BIN

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 3.1 KiB After Width:  |  Height:  |  Size: 3.1 KiB

util/test/data/D3D12_Overlay_Test/DebugOverlay.Depth.png

BIN

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 1.1 KiB After Width:  |  Height:  |  Size: 1.4 KiB

util/test/data/D3D12_Overlay_Test/DebugOverlay.Drawcall.png

BIN

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 1.3 KiB After Width:  |  Height:  |  Size: 1.4 KiB

util/test/data/D3D12_Overlay_Test/DebugOverlay.QuadOverdrawDraw.png

BIN

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 1.1 KiB After Width:  |  Height:  |  Size: 1.2 KiB

util/test/data/D3D12_Overlay_Test/DebugOverlay.QuadOverdrawPass.png

BIN

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 1.8 KiB After Width:  |  Height:  |  Size: 1.9 KiB

util/test/data/D3D12_Overlay_Test/DebugOverlay.Stencil.png

BIN

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 1.1 KiB After Width:  |  Height:  |  Size: 1.3 KiB

util/test/data/D3D12_Overlay_Test/DebugOverlay.TriangleSizeDraw.png

BIN

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 1.0 KiB After Width:  |  Height:  |  Size: 1.1 KiB

util/test/data/D3D12_Overlay_Test/DebugOverlay.TriangleSizePass.png

BIN

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 1.6 KiB After Width:  |  Height:  |  Size: 1.7 KiB

util/test/data/D3D12_Overlay_Test/backbuffer.png

BIN

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 3.7 KiB After Width:  |  Height:  |  Size: 3.8 KiB

util/test/data/D3D12_Overlay_Test/depth.png

BIN

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 2.2 KiB After Width:  |  Height:  |  Size: 2.6 KiB

util/test/data/D3D12_Overlay_Test/stencil.png

BIN

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 1.4 KiB After Width:  |  Height:  |  Size: 1.4 KiB