lee/renderdoc
1
0 Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-11-10 07:53:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

Change API enums to enum class, remove now redundant prefixing

Browse Source 
* This gives a little nicer syntax, a bit better type safety, and also
  reflects better for SWIG bindings. Overall it's a minor change but
  better.
* We don't update the C# UI at all, since it's soon to be removed and
  not worth the effort/code churn.
* For now so we're ABI compatible with C#, all enums are uint32_t, but
  that is an obvious optimisation in future to reduce struct packing.
* We avoid 'None' as an enum value, because it's a reserved word in
  python so will cause problems generating bindings.
This commit is contained in:
baldurk committed 2017-04-18 14:57:33 +01:00
1 parent 71e779a08f
commit d40fc8471d
158 files changed
+6386 -6176
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

qrenderdoc/Windows/Dialogs/CaptureDialog.cpp
+8 -8
View File
@@ -282,20 +282,20 @@ void CaptureDialog::on_vulkanLayerWarn_clicked()
{
QString caption = tr("Configure Vulkan layer settings in registry?");
uint32_t flags = 0;
VulkanLayerFlags flags = VulkanLayerFlags::NoFlags;
rdctype::array<rdctype::str> myJSONs;
rdctype::array<rdctype::str> otherJSONs;
RENDERDOC_NeedVulkanLayerRegistration(&flags, &myJSONs, &otherJSONs);
const bool hasOtherJSON = (flags & eVulkan_OtherInstallsRegistered);
const bool thisRegistered = (flags & eVulkan_ThisInstallRegistered);
const bool needElevation = (flags & eVulkan_NeedElevation);
const bool couldElevate = (flags & eVulkan_CouldElevate);
const bool registerAll = (flags & eVulkan_RegisterAll);
const bool updateAllowed = (flags & eVulkan_UpdateAllowed);
const bool hasOtherJSON = bool(flags & VulkanLayerFlags::OtherInstallsRegistered);
const bool thisRegistered = bool(flags & VulkanLayerFlags::ThisInstallRegistered);
const bool needElevation = bool(flags & VulkanLayerFlags::NeedElevation);
const bool couldElevate = bool(flags & VulkanLayerFlags::CouldElevate);
const bool registerAll = bool(flags & VulkanLayerFlags::RegisterAll);
const bool updateAllowed = bool(flags & VulkanLayerFlags::UpdateAllowed);
if(flags & eVulkan_Unfixable)
if(flags & VulkanLayerFlags::Unfixable)
{
QString msg =
tr("There is an unfixable problem with your vulkan layer configuration. Please consult the "