lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-05-29 13:20:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Change API enums to enum class, remove now redundant prefixing

Browse Source 
* This gives a little nicer syntax, a bit better type safety, and also
  reflects better for SWIG bindings. Overall it's a minor change but
  better.
* We don't update the C# UI at all, since it's soon to be removed and
  not worth the effort/code churn.
* For now so we're ABI compatible with C#, all enums are uint32_t, but
  that is an obvious optimisation in future to reduce struct packing.
* We avoid 'None' as an enum value, because it's a reserved word in
  python so will cause problems generating bindings.
This commit is contained in:
baldurk
2017-04-06 14:09:00 +01:00
parent 71e779a08f
commit d40fc8471d
158 changed files with 6386 additions and 6176 deletions
Download Patch File Download Diff File Expand all files Collapse all files
qrenderdoc/Windows/Dialogs/EnvironmentEditor.cpp
+9 -8
View File
@@ -51,7 +51,8 @@ EnvironmentEditor::EnvironmentEditor(QWidget *parent)
QObject::connect(ui->appendValue, &QRadioButton::toggled, separatorLambda);
ui->separator->addItems({
ToQStr(eEnvSep_Platform), ToQStr(eEnvSep_SemiColon), ToQStr(eEnvSep_Colon), ToQStr(eEnvSep_None),
ToQStr(EnvSep::Platform), ToQStr(EnvSep::SemiColon), ToQStr(EnvSep::Colon),
ToQStr(EnvSep::NoSep),
});
ui->separator->setCurrentIndex(0);
@@ -120,11 +121,11 @@ void EnvironmentEditor::on_variables_currentItemChanged(QTreeWidgetItem *current
ui->value->setText(mod.value);
ui->separator->setCurrentIndex((int)mod.separator);
if(mod.type == eEnvMod_Set)
if(mod.type == EnvMod::Set)
ui->setValue->setChecked(true);
else if(mod.type == eEnvMod_Append)
else if(mod.type == EnvMod::Append)
ui->appendValue->setChecked(true);
else if(mod.type == eEnvMod_Prepend)
else if(mod.type == EnvMod::Prepend)
ui->prependValue->setChecked(true);
}
}
@@ -134,14 +135,14 @@ void EnvironmentEditor::on_addUpdate_clicked()
EnvironmentModification mod;
mod.variable = ui->name->text();
mod.value = ui->value->text();
mod.separator = (EnvironmentSeparator)ui->separator->currentIndex();
mod.separator = (EnvSep)ui->separator->currentIndex();
if(ui->appendValue->isChecked())
mod.type = eEnvMod_Append;
mod.type = EnvMod::Append;
else if(ui->prependValue->isChecked())
mod.type = eEnvMod_Prepend;
mod.type = EnvMod::Prepend;
else
mod.type = eEnvMod_Set;
mod.type = EnvMod::Set;
addModification(mod, false);