From d4c1919a9c3d2a493795becb9bc160795cd07f30 Mon Sep 17 00:00:00 2001 From: Jake Turner Date: Thu, 22 May 2025 14:00:38 +0100 Subject: [PATCH] Fix assert check on format number of components for AtomicBinOp on UAV Tweak error message about AtomicBinOp storing to out of bounds or unbound resource --- renderdoc/driver/shaders/dxil/dxil_debug.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/renderdoc/driver/shaders/dxil/dxil_debug.cpp b/renderdoc/driver/shaders/dxil/dxil_debug.cpp index 1f19b87e8..58dbc4de6 100644 --- a/renderdoc/driver/shaders/dxil/dxil_debug.cpp +++ b/renderdoc/driver/shaders/dxil/dxil_debug.cpp @@ -3333,7 +3333,7 @@ bool ThreadState::ExecuteInstruction(DebugAPIWrapper *apiWrapper, RDCASSERTNOTEQUAL(stride, 1); RDCASSERTEQUAL(result.columns, 1); - RDCASSERTEQUAL(fmt.numComps, result.columns); + RDCASSERTEQUAL(fmt.numComps * fmt.byteWidth, GetElementByteSize(result.type)); RDCASSERTNOTEQUAL(stride, 0); RDCASSERTNOTEQUAL(fmt.compType, CompType::Typeless); @@ -3515,7 +3515,8 @@ bool ThreadState::ExecuteInstruction(DebugAPIWrapper *apiWrapper, // NULL resource or out of bounds if((!texData && elemIdx >= numElems) || (texData && dataOffset >= dataSize)) { - RDCERR("Ignoring store to unbound resource %s", GetArgumentName(1).c_str()); + RDCERR("Ignoring store to unbound resource or out of bounds store %s", + GetArgumentName(1).c_str()); } else {