lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-05-04 09:00:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do our best to determine suffix for unknown file filters. Closes #1993

Browse Source 
* We work around a GNOME bug here by ignoring a selected filter if it's the
  empty string. For all other unknown filters we try to determine the suffix on
  the fly.
This commit is contained in:
baldurk
2020-08-07 16:12:29 +01:00
parent de7030ea8c
commit d9fc87ec2a
1 changed files with 37 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
qrenderdoc/Code/QRDUtils.cpp
+37 -1
View File
@@ -1739,7 +1739,43 @@ QString RDDialog::getSaveFileName(QWidget *parent, const QString &caption, const
fd.setDefaultSuffix(defaultSuffixes.first());
QObject::connect(&fd, &QFileDialog::filterSelected, [&](const QString &filter) {
int i = fd.nameFilters().indexOf(filter);
fd.setDefaultSuffix(defaultSuffixes.value(i));
// we expect that this should always be non-negative because only the filters we know about
// should get selected
if(i >= 0)
{
fd.setDefaultSuffix(defaultSuffixes.value(i));
}
else
{
// GNOME has a bug that passes an empty string to filterSelected, so we ignore it with a
// warning.
if(filter == QString())
{
qWarning() << "Empty filter string passed to QFileDialog::filterSelected. "
<< "Ignoring this as a likely GNOME bug, default suffix is still: "
<< fd.defaultSuffix();
}
else
{
// some filter that we don't recognise was selected! Try to figure out the suffix on the
// fly
QStringList suffixes = getDefaultSuffixesFromFilter(filter);
if(suffixes.empty())
{
qWarning() << "Unknown filter " << filter << " selected. "
<< "Couldn't determine filename suffix, default suffix is still: "
<< fd.defaultSuffix();
}
else
{
fd.setDefaultSuffix(suffixes[0]);
qWarning() << "Unknown filter " << filter << " selected. "
<< "Using default suffix: " << fd.defaultSuffix();
}
}
}
});
show(&fd);