From e2fce8cad100c46c50f87ecdacb886c64b63c093 Mon Sep 17 00:00:00 2001 From: baldurk Date: Thu, 30 Apr 2020 16:02:26 +0100 Subject: [PATCH] Fix crash if accessed resource is unbound --- qrenderdoc/Windows/ShaderViewer.cpp | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/qrenderdoc/Windows/ShaderViewer.cpp b/qrenderdoc/Windows/ShaderViewer.cpp index 3e8aa4d83..400861c88 100644 --- a/qrenderdoc/Windows/ShaderViewer.cpp +++ b/qrenderdoc/Windows/ShaderViewer.cpp @@ -3371,14 +3371,11 @@ RDTreeWidgetItem *ShaderViewer::makeAccessedResourceNode(const ShaderVariable &v } } - RDTreeWidgetItem *node = NULL; + RDTreeWidgetItem *node = new RDTreeWidgetItem({v.name, typeName, ToQStr(resId)}); if(resId != ResourceId()) - { - node = new RDTreeWidgetItem({v.name, typeName, ToQStr(resId)}); node->setTag(QVariant::fromValue(AccessedResourceTag(bp, v.type))); - if(modified) - node->setForegroundColor(QColor(Qt::red)); - } + if(modified) + node->setForegroundColor(QColor(Qt::red)); return node; }