From e4e2d781bb330a49afc063409ef5ddc98653257c Mon Sep 17 00:00:00 2001 From: Alex Vakulenko Date: Tue, 15 Dec 2020 17:18:11 -0500 Subject: [PATCH] Fix access mode for ::popen() call in ggp OS wrapper popen's access mode was accidentally changed from string to enum used in FileIO::open() wrappers. This is a posix function and should keep using the string. --- renderdoc/os/posix/ggp/ggp_callstack.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/renderdoc/os/posix/ggp/ggp_callstack.cpp b/renderdoc/os/posix/ggp/ggp_callstack.cpp index 4f4923181..822fd9bf4 100644 --- a/renderdoc/os/posix/ggp/ggp_callstack.cpp +++ b/renderdoc/os/posix/ggp/ggp_callstack.cpp @@ -181,7 +181,7 @@ private: uint64_t relative = addr - m_Modules[i].base + m_Modules[i].offset; rdcstr cmd = StringFormat::Fmt("addr2line -fCe \"%s\" 0x%llx", m_Modules[i].path, relative); - FILE *f = ::popen(cmd.c_str(), FileIO::ReadText); + FILE *f = ::popen(cmd.c_str(), "r"); char result[2048] = {0}; fread(result, 1, 2047, f);