From e9dcd4b58f5b75f32fbd519fbe9fbd8342a7b36e Mon Sep 17 00:00:00 2001 From: baldurk Date: Mon, 21 Sep 2020 14:37:29 +0100 Subject: [PATCH] Fix out of bounds check to not allow indexing 1 too far in members array --- renderdoc/driver/shaders/spirv/spirv_debug_setup.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/renderdoc/driver/shaders/spirv/spirv_debug_setup.cpp b/renderdoc/driver/shaders/spirv/spirv_debug_setup.cpp index d02830f26..23ecc514b 100644 --- a/renderdoc/driver/shaders/spirv/spirv_debug_setup.cpp +++ b/renderdoc/driver/shaders/spirv/spirv_debug_setup.cpp @@ -1332,7 +1332,7 @@ ShaderVariable Debugger::MakeCompositePointer(const ShaderVariable &base, Id id, while(i < indices.size() && !leaf->members.empty()) { uint32_t idx = indices[i++]; - if(idx > leaf->members.size()) + if(idx >= leaf->members.size()) { apiWrapper->AddDebugMessage( MessageCategory::Execution, MessageSeverity::High, MessageSource::RuntimeWarning,