From ec74c134655b0de91e907a04ac33aad2c363891f Mon Sep 17 00:00:00 2001 From: William Pearson Date: Mon, 8 Apr 2024 18:16:51 -0700 Subject: [PATCH] Fix typo in AndroidAPKInstallFailed message This message can be seen if the USB cable connecting the device is removed while the `adb install` command is running. (I ran into this by accident due to a low-quality cable.) The previous message was this: > Failed to install Android remote server for unknown reasons: Couldn't install APK(s). stderr: adb.exe: device '00000a740f4e6d93' not found > . > > lease check that your device is connected and accessible to adb, and that installing APKs over USB is allowed. This does also include a newline before a period, which looks a bit strange but I don't see a quick fix for that while keeping stderr, and the stderr output is fairly useful. --- qrenderdoc/Windows/MainWindow.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qrenderdoc/Windows/MainWindow.cpp b/qrenderdoc/Windows/MainWindow.cpp index d62ff4f48..6399da7b8 100644 --- a/qrenderdoc/Windows/MainWindow.cpp +++ b/qrenderdoc/Windows/MainWindow.cpp @@ -3139,7 +3139,7 @@ void MainWindow::showLaunchError(ResultDetails result) break; case ResultCode::AndroidAPKFolderNotFound: message = result.Message(); break; case ResultCode::AndroidAPKInstallFailed: - message = tr("%1.\n\nlease check that your device is connected and accessible to " + message = tr("%1.\n\nPlease check that your device is connected and accessible to " "adb, and that installing APKs over USB is allowed.") .arg(result.Message()); break;