From eeac0568164e852e5e06d4f82325fa6d33814d2e Mon Sep 17 00:00:00 2001 From: Jake Turner Date: Tue, 22 Apr 2025 11:41:15 +0100 Subject: [PATCH] VK and D3D12 Workgroup & Subgroup Zoo tests fail on Asserts or Errors Check the renderdoc log for lines matching "Assertion" or "Error" Using new helper function in testcase.py def check_renderdoc_log(self, asserts: bool = True, errors: bool = True): --- util/test/demos/vk/vk_workgroup_zoo.cpp | 2 +- util/test/rdtest/shared/Subgroup_Zoo.py | 4 +++- util/test/rdtest/shared/Workgroup_Zoo.py | 4 +++- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/util/test/demos/vk/vk_workgroup_zoo.cpp b/util/test/demos/vk/vk_workgroup_zoo.cpp index b3855e2fe..d12d61bac 100644 --- a/util/test/demos/vk/vk_workgroup_zoo.cpp +++ b/util/test/demos/vk/vk_workgroup_zoo.cpp @@ -130,7 +130,7 @@ void main() { vec4 data = vec4(0); uint id = gl_SubgroupInvocationID; - gsmUint4[id] = id; + gsmUint4[id] = id.xxxx; SetOutput(data); if(IsTest(0)) diff --git a/util/test/rdtest/shared/Subgroup_Zoo.py b/util/test/rdtest/shared/Subgroup_Zoo.py index a912fa699..d6943c826 100644 --- a/util/test/rdtest/shared/Subgroup_Zoo.py +++ b/util/test/rdtest/shared/Subgroup_Zoo.py @@ -272,4 +272,6 @@ class Subgroup_Zoo(rdtest.TestCase): overallFailed |= self.check_compute_tests(compute_dims, thread_checks) if overallFailed: - raise rdtest.TestFailureException("Some tests were not as expected") \ No newline at end of file + raise rdtest.TestFailureException("Some tests were not as expected") + + self.check_renderdoc_log() \ No newline at end of file diff --git a/util/test/rdtest/shared/Workgroup_Zoo.py b/util/test/rdtest/shared/Workgroup_Zoo.py index c6d33331a..dc28f22f1 100644 --- a/util/test/rdtest/shared/Workgroup_Zoo.py +++ b/util/test/rdtest/shared/Workgroup_Zoo.py @@ -25,4 +25,6 @@ class Workgroup_Zoo(rdtest.Subgroup_Zoo): ] if self.check_compute_tests(compute_dims, thread_checks): - raise rdtest.TestFailureException("Some tests were not as expected") \ No newline at end of file + raise rdtest.TestFailureException("Some tests were not as expected") + + self.check_renderdoc_log()