lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-05-29 13:20:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Change verify map writes capture option to verify buffer access.

Browse Source 
* This option will now toggle on the behaviour to fill undefined buffer contents
  with a marker value, both if they're created without data (it will be zero
  filled instead) or mapped with discard (it will keep the old contents
  instead).
* There were too many hard to find problems or misconceptions about the buffer
  filling for it to be useful. Now it will be opt-in instead.
This commit is contained in:
baldurk
2018-11-23 11:25:39 +00:00
parent 667d40382b
commit f75b5e235e
12 changed files with 107 additions and 73 deletions
Download Patch File Download Diff File Expand all files Collapse all files
qrenderdoc/Code/Interface/QRDInterface.cpp
+6 -2
View File
@@ -99,7 +99,7 @@ CaptureSettings::operator QVariant() const
opts[lit("captureCallstacks")] = options.captureCallstacks;
opts[lit("captureCallstacksOnlyDraws")] = options.captureCallstacksOnlyDraws;
opts[lit("delayForDebugger")] = options.delayForDebugger;
opts[lit("verifyMapWrites")] = options.verifyMapWrites;
opts[lit("verifyBufferAccess")] = options.verifyBufferAccess;
opts[lit("hookIntoChildren")] = options.hookIntoChildren;
opts[lit("refAllResources")] = options.refAllResources;
opts[lit("captureAllCmdLists")] = options.captureAllCmdLists;
@@ -135,7 +135,11 @@ CaptureSettings::CaptureSettings(const QVariant &v)
options.captureCallstacks = opts[lit("captureCallstacks")].toBool();
options.captureCallstacksOnlyDraws = opts[lit("captureCallstacksOnlyDraws")].toBool();
options.delayForDebugger = opts[lit("delayForDebugger")].toUInt();
options.verifyMapWrites = opts[lit("verifyMapWrites")].toBool();
// old name for verifyBufferAccess was verifyMapWrites, so use that as a fallback
if(opts.contains(lit("verifyBufferAccess")))
options.verifyBufferAccess = opts[lit("verifyBufferAccess")].toBool();
else
options.verifyBufferAccess = opts[lit("verifyMapWrites")].toBool();
options.hookIntoChildren = opts[lit("hookIntoChildren")].toBool();
options.refAllResources = opts[lit("refAllResources")].toBool();
options.captureAllCmdLists = opts[lit("captureAllCmdLists")].toBool();
qrenderdoc/Windows/Dialogs/CaptureDialog.cpp
+2 -2
View File
@@ -872,7 +872,7 @@ void CaptureDialog::SetSettings(CaptureSettings settings)
ui->RefAllResources->setChecked(settings.options.refAllResources);
ui->CaptureAllCmdLists->setChecked(settings.options.captureAllCmdLists);
ui->DelayForDebugger->setValue(settings.options.delayForDebugger);
ui->VerifyMapWrites->setChecked(settings.options.verifyMapWrites);
ui->VerifyBufferAccess->setChecked(settings.options.verifyBufferAccess);
ui->AutoStart->setChecked(settings.autoStart);
// force flush this state
@@ -907,7 +907,7 @@ CaptureSettings CaptureDialog::Settings()
ret.options.refAllResources = ui->RefAllResources->isChecked();
ret.options.captureAllCmdLists = ui->CaptureAllCmdLists->isChecked();
ret.options.delayForDebugger = (uint32_t)ui->DelayForDebugger->value();
ret.options.verifyMapWrites = ui->VerifyMapWrites->isChecked();
ret.options.verifyBufferAccess = ui->VerifyBufferAccess->isChecked();
return ret;
}
qrenderdoc/Windows/Dialogs/CaptureDialog.ui
+5 -2
View File
@@ -520,9 +520,12 @@
</widget>
</item>
<item>
<widget class="QCheckBox" name="VerifyMapWrites">
<widget class="QCheckBox" name="VerifyBufferAccess">
<property name="toolTip">
<string>When enabled, verify some buffer access on OpenGL and D3D11. This initialises buffers with undefined contents on creation to 0xdddddddd instead of 0x0, and verifies that Map() bounds are not overrun.</string>
</property>
<property name="text">
<string>Verify Map() Writes</string>
<string>Verify Buffer Access</string>
</property>
</widget>
</item>