Change verify map writes capture option to verify buffer access.

* This option will now toggle on the behaviour to fill undefined buffer contents
  with a marker value, both if they're created without data (it will be zero
  filled instead) or mapped with discard (it will keep the old contents
  instead).
* There were too many hard to find problems or misconceptions about the buffer
  filling for it to be useful. Now it will be opt-in instead.
This commit is contained in:
baldurk
2018-11-23 11:25:39 +00:00
parent 667d40382b
commit f75b5e235e
12 changed files with 107 additions and 73 deletions
+2 -2
View File
@@ -872,7 +872,7 @@ void CaptureDialog::SetSettings(CaptureSettings settings)
ui->RefAllResources->setChecked(settings.options.refAllResources);
ui->CaptureAllCmdLists->setChecked(settings.options.captureAllCmdLists);
ui->DelayForDebugger->setValue(settings.options.delayForDebugger);
ui->VerifyMapWrites->setChecked(settings.options.verifyMapWrites);
ui->VerifyBufferAccess->setChecked(settings.options.verifyBufferAccess);
ui->AutoStart->setChecked(settings.autoStart);
// force flush this state
@@ -907,7 +907,7 @@ CaptureSettings CaptureDialog::Settings()
ret.options.refAllResources = ui->RefAllResources->isChecked();
ret.options.captureAllCmdLists = ui->CaptureAllCmdLists->isChecked();
ret.options.delayForDebugger = (uint32_t)ui->DelayForDebugger->value();
ret.options.verifyMapWrites = ui->VerifyMapWrites->isChecked();
ret.options.verifyBufferAccess = ui->VerifyBufferAccess->isChecked();
return ret;
}