lee/renderdoc
1
0
Fork 0
mirror of https://github.com/baldurk/renderdoc.git synced 2026-08-05 06:11:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Report vulkan dynamic offsets separately for manual application

Browse Source 
* Baking these into descriptors when we get arbitrary 'GetDescriptor' queries
  independent of the bound descriptor sets is not possible - a descriptor set
  could be in theory bound twice to two places with different dynamic offsets.
* Instead we report these as part of the pipeline states and the abstraction &
  replay API consumer will need to manually apply them to get the true buffer
  offset.
* The offsets are indexed by descriptor storage byte offset for easier
  processing (the dynamic offset struct can be turned into a pair and used to
  initialise a dict)
This commit is contained in:
baldurk
2024-04-10 16:12:32 +01:00
parent d03c379f3d
commit fa22c7c7fc
4 changed files with 116 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
renderdoc/api/replay/vk_pipestate.h
+44
View File
@@ -314,6 +314,39 @@ If :data:`descriptorCount` is 1 then this list has only one element and the bind
rdcarray<BindingElement> binds;
};
DOCUMENT("A dynamic offset applied to a single descriptor access.");
struct DynamicOffset
{
DOCUMENT("");
DynamicOffset() = default;
DynamicOffset(const DynamicOffset &) = default;
DynamicOffset &operator=(const DynamicOffset &) = default;
bool operator==(const DynamicOffset &o) const
{
return descriptorByteOffset == o.descriptorByteOffset &&
dynamicBufferByteOffset == o.dynamicBufferByteOffset;
}
bool operator<(const DynamicOffset &o) const
{
if(!(descriptorByteOffset == o.descriptorByteOffset))
return descriptorByteOffset < o.descriptorByteOffset;
if(!(dynamicBufferByteOffset == o.dynamicBufferByteOffset))
return dynamicBufferByteOffset < o.dynamicBufferByteOffset;
return false;
}
DOCUMENT(R"(The offset in bytes to the descriptor in the storage.
:type: int
)");
uint64_t descriptorByteOffset = 0;
DOCUMENT(R"(The dynamic offset to apply to the buffer in bytes.
:type: int
)");
uint64_t dynamicBufferByteOffset = 0;
};
DOCUMENT("The contents of a descriptor set.");
struct DescriptorSet
{
@@ -363,6 +396,16 @@ offset and size into this buffer.
:type: bytes
)");
bytebuf inlineData;
DOCUMENT(R"(A list of dynamic offsets to be applied to specific bindings, on top of the contents
of their descriptors.
.. note::
The returned values from :meth:`PipeState.GetConstantBuffer` already have these offsets applied.
:type: List[VKDynamicOffset]
)");
rdcarray<DynamicOffset> dynamicOffsets;
};
DOCUMENT("Describes the object and descriptor set bindings of a Vulkan pipeline object.");
@@ -1477,6 +1520,7 @@ struct State
DECLARE_REFLECTION_STRUCT(VKPipe::BindingElement);
DECLARE_REFLECTION_STRUCT(VKPipe::DescriptorBinding);
DECLARE_REFLECTION_STRUCT(VKPipe::DynamicOffset);
DECLARE_REFLECTION_STRUCT(VKPipe::DescriptorSet);
DECLARE_REFLECTION_STRUCT(VKPipe::Pipeline);
DECLARE_REFLECTION_STRUCT(VKPipe::IndexBuffer);