From fd249cf84390143753d05b994b74e2955dcb054e Mon Sep 17 00:00:00 2001 From: baldurk Date: Mon, 12 Nov 2018 14:50:42 +0000 Subject: [PATCH] Don't delete and recreate QCompleter when changing list of items --- qrenderdoc/Windows/Dialogs/EnvironmentEditor.cpp | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/qrenderdoc/Windows/Dialogs/EnvironmentEditor.cpp b/qrenderdoc/Windows/Dialogs/EnvironmentEditor.cpp index aa0cf1593..142491f5d 100644 --- a/qrenderdoc/Windows/Dialogs/EnvironmentEditor.cpp +++ b/qrenderdoc/Windows/Dialogs/EnvironmentEditor.cpp @@ -26,6 +26,7 @@ #include #include #include +#include #include "Code/QRDUtils.h" #include "ui_EnvironmentEditor.h" @@ -223,15 +224,11 @@ void EnvironmentEditor::addModification(EnvironmentModification mod, bool silent ui->variables->setSelectedItem(node); - delete m_Completer; - QStringList names; for(int i = 0; i < ui->variables->topLevelItemCount(); i++) names << ui->variables->topLevelItem(i)->text(0); - m_Completer = new QCompleter(names, this); - - ui->name->setCompleter(m_Completer); + m_Completer->setModel(new QStringListModel(names, m_Completer)); } QList EnvironmentEditor::modifications()