From ffbb2da206f4379c2e039523cdba90516a3f8458 Mon Sep 17 00:00:00 2001 From: baldurk Date: Mon, 9 Jan 2017 11:31:55 +0000 Subject: [PATCH] As a hack, only check AMD driver for broken texelFetch on windows * Without this, the RADV open source driver also gets checked, and its version is 0.0.1 so it gets marked as buggy. * Unfortunately there's not a great way to identify different drivers for the same piece of hardware (ie. PCI IDs are the same). --- renderdoc/driver/vulkan/vk_debug.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/renderdoc/driver/vulkan/vk_debug.cpp b/renderdoc/driver/vulkan/vk_debug.cpp index 16a1cfc3d..e6b38b374 100644 --- a/renderdoc/driver/vulkan/vk_debug.cpp +++ b/renderdoc/driver/vulkan/vk_debug.cpp @@ -709,6 +709,10 @@ VulkanDebugManager::VulkanDebugManager(WrappedVulkan *driver, VkDevice dev) texelFetchBrokenDriver = true; } +// only check this on windows. This is a bit of a hack, as really we want to check if we're +// using the AMD official driver, but there's not a great other way to distinguish it from +// the RADV open source driver. +#if ENABLED(RDOC_WIN32) if(driverVersion.IsAMD()) { // for AMD the bugfix version isn't clear as version numbering wasn't strong for a while, but @@ -718,6 +722,7 @@ VulkanDebugManager::VulkanDebugManager(WrappedVulkan *driver, VkDevice dev) if(driverVersion.Major() < 1) texelFetchBrokenDriver = true; } +#endif if(texelFetchBrokenDriver) {