/****************************************************************************** * The MIT License (MIT) * * Copyright (c) 2017-2019 Baldur Karlsson * * Permission is hereby granted, free of charge, to any person obtaining a copy * of this software and associated documentation files (the "Software"), to deal * in the Software without restriction, including without limitation the rights * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell * copies of the Software, and to permit persons to whom the Software is * furnished to do so, subject to the following conditions: * * The above copyright notice and this permission notice shall be included in * all copies or substantial portions of the Software. * * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN * THE SOFTWARE. ******************************************************************************/ #pragma once // verify the interface. // We check that docstrings aren't duplicated, which is a symptom of missing DOCUMENT() // macros around newly added classes/members. // For enums, verify that all constants are documented in the parent docstring // Generally we ensure naming is roughly OK: // * types, member functions, and enum values must match the regexp /[A-Z][a-zA-Z0-9]+/ // ie. we don't use underscore_seperated_words or mixedCase / camelCase. // * data members should be mixedCase / camelCase. So matching /[a-z][a-zA-Z0-9]+/ // This isn't quite python standards but it fits best with the C++ code and the important // thing is that it's self-consistent. enum class NameType { Type, EnumValue, Method, Member, }; inline bool checkname(const char *baseType, std::string name, NameType nameType) { // skip __ prefixed names if(name.length() > 2 && name[0] == '_' && name[1] == '_') return false; // skip any rdctype based types that are converted into equivalent python types if((baseType && strstr(baseType, "rdcarray")) || name.find("rdcarray") != std::string::npos) return false; if((baseType && strstr(baseType, "bytebuf")) || name.find("bytebuf") != std::string::npos) return false; if((baseType && strstr(baseType, "rdcstr")) || name.find("rdcstr") != std::string::npos) return false; if((baseType && strstr(baseType, "StructuredBufferList")) || name.find("StructuredBufferList") != std::string::npos) return false; if((baseType && strstr(baseType, "StructuredChunkList")) || name.find("StructuredChunkList") != std::string::npos) return false; if((baseType && strstr(baseType, "StructuredObjectList")) || name.find("StructuredObjectList") != std::string::npos) return false; // allow the config to have different names if((baseType && strstr(baseType, "PersistantConfig")) || name.find("PersistantConfig") != std::string::npos) return false; // skip swig internal type if((baseType && strstr(baseType, "SwigPyObject")) || name.find("SwigPyObject") != std::string::npos) return false; // remove the module prefix, if this is a type name we're checking if(!strncmp(name.c_str(), "renderdoc.", 10)) name.erase(0, 10); if(!strncmp(name.c_str(), "qrenderdoc.", 11)) name.erase(0, 11); // skip a few well-known members if(name == "this" || name == "thisown") return false; bool member = (nameType == NameType::Member); // look for invalid name bool badfirstChar = false; if(member) badfirstChar = name[0] < 'a' || name[0] > 'z'; else badfirstChar = name[0] < 'A' || name[0] > 'Z'; if(badfirstChar || name.find('_') != std::string::npos) { const char *nameTypeStr = ""; switch(nameType) { case NameType::EnumValue: nameTypeStr = "enum value"; break; case NameType::Member: nameTypeStr = "member variable"; break; case NameType::Method: nameTypeStr = "method"; break; case NameType::Type: nameTypeStr = "type"; break; } snprintf(convert_error, sizeof(convert_error) - 1, "Name of %s '%s.%s' does not match naming scheme.\n" "Should start with %s letter and not contain underscores", nameTypeStr, baseType, name.c_str(), member ? "lowercase" : "uppercase"); RENDERDOC_LogMessage(LogType::Error, "QTRD", __FILE__, __LINE__, convert_error); return true; } return false; } inline bool check_interface(swig_type_info **swig_types, size_t numTypes) { // track all errors and fatal error at the end, so we see all of the problems at once instead of // requiring rebuilds over and over. // This does mean that e.g. a duplicated docstring could be reported multiple times but that's not // the end of the world. bool errors_found = false; std::set docstrings; for(size_t i = 0; i < numTypes; i++) { SwigPyClientData *typeinfo = (SwigPyClientData *)swig_types[i]->clientdata; // opaque types have no typeinfo, skip these if(!typeinfo) continue; PyTypeObject *typeobj = typeinfo->pytype; std::string typedoc = typeobj->tp_doc; auto result = docstrings.insert(typedoc); if(!result.second) { snprintf(convert_error, sizeof(convert_error) - 1, "Duplicate docstring '%s' found on struct '%s' - are you missing a DOCUMENT()?", typedoc.c_str(), typeobj->tp_name); RENDERDOC_LogMessage(LogType::Error, "QTRD", __FILE__, __LINE__, convert_error); errors_found = true; } errors_found |= checkname("renderdoc", typeobj->tp_name, NameType::Type); PyObject *dict = typeobj->tp_dict; // check the object's dict to see if this is an enum (or struct with constants). // We require ALL constants be documented in a docstring with data:: directives if(dict && PyDict_Check(dict)) { PyObject *keys = PyDict_Keys(dict); if(keys) { std::set constants; Py_ssize_t len = PyList_Size(keys); for(Py_ssize_t i = 0; i < len; i++) { PyObject *key = PyList_GetItem(keys, i); PyObject *value = PyDict_GetItem(dict, key); // if this key is a string (it should be) if(PyUnicode_Check(key)) { char *str = NULL; Py_ssize_t len = 0; PyObject *bytes = PyUnicode_AsUTF8String(key); PyBytes_AsStringAndSize(bytes, &str, &len); if(str == NULL || len == 0) { snprintf(convert_error, sizeof(convert_error) - 1, "Couldn't get member name for %i'th member of '%s'", (int)i, typeobj->tp_name); RENDERDOC_LogMessage(LogType::Error, "QTRD", __FILE__, __LINE__, convert_error); errors_found = true; } else { std::string name(str, str + len); NameType nameType = NameType::Member; // if the value is an integer, it's a constant if(PyLong_Check(value)) { constants.insert(name); nameType = NameType::EnumValue; } // if it's a callable it's a method, ignore it if(!PyCallable_Check(value) && !PyType_IsSubtype(value->ob_type, &PyStaticMethod_Type)) errors_found |= checkname(typeobj->tp_name, name, nameType); } Py_DecRef(bytes); } } Py_DecRef(keys); if(!constants.empty()) { std::set documented; const char *docstring = typedoc.data(); const char identifier[] = ".. data::"; const char *datadoc = strstr(docstring, identifier); while(datadoc) { datadoc += sizeof(identifier) - 1; while(isspace(*datadoc)) datadoc++; const char *eol = strchr(datadoc, '\n'); if(!eol) break; documented.insert(std::string(datadoc, eol)); datadoc = strstr(datadoc, identifier); } for(auto it = constants.begin(); it != constants.end(); ++it) { // allow enums with First or Count members to be undocumented if(*it == "First" || *it == "Count") continue; if(documented.find(*it) == documented.end()) { snprintf(convert_error, sizeof(convert_error) - 1, "'%s::%s' is not documented in class docstring", typeobj->tp_name, it->c_str()); RENDERDOC_LogMessage(LogType::Error, "QTRD", __FILE__, __LINE__, convert_error); errors_found = true; } } } } } PyMethodDef *method = typeobj->tp_methods; while(method->ml_doc) { std::string method_doc = method->ml_doc; errors_found |= checkname(typeobj->tp_name, method->ml_name, NameType::Method); size_t i = 0; while(method_doc[i] == '\n') i++; // skip the first line as it's autodoc generated i = method_doc.find('\n', i); if(i != std::string::npos) { while(method_doc[i] == '\n') i++; method_doc.erase(0, i); result = docstrings.insert(method_doc); if(!result.second) { snprintf( convert_error, sizeof(convert_error) - 1, "Duplicate docstring '%s' found on method '%s.%s' - are you missing a DOCUMENT()?", method_doc.c_str(), typeobj->tp_name, method->ml_name); RENDERDOC_LogMessage(LogType::Error, "QTRD", __FILE__, __LINE__, convert_error); errors_found = true; } } method++; } } return errors_found; }